Build failure on Fedora with clang

[sneumann]

Hi, we have a report on a build failure on Fedora (see https://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-clang for the actual setup) and mzR.log for the logs.

The actual error seems to be

clang++ -std=gnu++11 -I"/data/gannet/ripley/R/R-clang/include" -DNDEBUG -I./boost_aux/ -I./boost/ -I. -D_LARGEFILE_SOURCE -DHAVE_PWIZ_MZML_LIB -D_NODEBUG    -I'/data/gannet/ripley/R/test-clang/Rcpp/include' -I'/data/gannet/ripley/R/test-clang/Rhdf5lib/include' -isystem /usr/local/clang/include   -fpic  -g -O3 -Wall -pedantic -frtti  -c pwiz/data/common/BinaryIndexStream.cpp -o pwiz/data/common/BinaryIndexStream.o
pwiz/data/common/BinaryIndexStream.cpp:159:15: error: cannot assign to non-static data member within const member function 'operator[]'
        next_ = _Off * value_size_;
        ~~~~~ ^

Yours, Steffen

[sneumann]

Sounds like the same issue as #244 , now also reported upstream as https://github.com/ProteoWizard/pwiz/issues/2028. For now we'll fix by re-applying https://github.com/sneumann/mzR/commit/d028ffbe3849e00c7051ca89cce5ca9c1806aa00 Yours, Steffen