Compilation fails: control reaches end of non-void function

[saskema]

Hi,

I'm trying to install mzR 3.18 from Bioconductor. The compilation (using g++ 13.2.1) fails with pwiz/data/msdata/MSData.cpp:1115:1: error: control reaches end of non-void function [-Werror=return-type].

Please see the full error message below:

pwiz/data/msdata/MSData.cpp: In member function 'virtual size_t pwiz::msdata::SpectrumList::findAbbreviated(const std::string&, char) const':
pwiz/data/msdata/MSData.cpp:1115:1: **error: control reaches end of non-void function [-Werror=return-type]
 1115 | }
      | ^**
cc1plus: some warnings being treated as errors
make: *** [/usr/lib64/R/etc/Makeconf:200: pwiz/data/msdata/MSData.o] Error 1
ERROR: compilation failed for package 'mzR'

My sessionInfo() is as follows:

R version 4.3.2 (2023-10-31)
Platform: x86_64-suse-linux-gnu (64-bit)
Running under: openSUSE Tumbleweed

Matrix products: default
BLAS:   /usr/lib64/R/lib/libRblas.so 
LAPACK: /usr/lib64/R/lib/libRlapack.so;  LAPACK version 3.11.0

locale:
[1] C

time zone: Etc/UTC
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
[1] BiocManager_1.30.22 compiler_4.3.2      tools_4.3.2      

Please let me know, if you need any further information.

[saskema]

Adding return size(); to line 1115 in src/pwiz/data/msdata/MSData.cpp did the trick.

I peeked at the ProteoWizard guys ;).