sneumann / mzR

This is the git repository matching the Bioconductor package mzR: parser for netCDF, mzXML, mzData and mzML files (mass spectrometry data)
40 stars 26 forks source link

Build on Windows/aarch64 #290

Closed sneumann closed 3 months ago

sneumann commented 3 months ago

Hi, we got a wonderful description of an issue, together with a patch to fix it from Tomas:

[....] unfortunately mzR cannot be built on Windows/aarch64. I've prepared a patch to fix it (attached).

Two problems are in the bundled boost. One of the problem has been fixed upstream in https://github.com/boostorg/numeric_conversion/commit/50a1eae942effb0a9b90724323ef8f2a67e7984a

and I've back-ported it.

Another problem from pwiz was just a missing cast.

The second problem in boost is an instance of https://cplusplus.github.io/CWG/issues/1344.html , which luckily is trivial to fix.

The boost problems would be also on other platforms and show up with LLVM, but I've only been testing on Windows.

In principle, Rtools already uses boost, a newer version that bundled in the package, so you could also consider using that (but it indeed may be you would have to update the other code, I've not tried that).

In either case, it would be great if you could fix the package so that it works also on Windows/aarch64 as described.

Thanks Tomas