boost/predef/compiler/digitalmars.h missing

lgatto commented 7 years ago

In file included from ./boost/boost/predef.h:13:0,
                 from ./boost/boost/smart_ptr/detail/yield_k.hpp:28,
                 from ./boost/boost/smart_ptr/detail/spinlock_sync.hpp:18,
                 from ./boost/boost/smart_ptr/detail/spinlock.hpp:50,
                 from ./boost/boost/smart_ptr/detail/spinlock_pool.hpp:25,
                 from ./boost/boost/smart_ptr/shared_ptr.hpp:34,
                 from ./boost/boost/shared_ptr.hpp:17,
                 from ./pwiz/data/msdata/RAMPAdapter.hpp:30,
                 from ramp.cpp:60:
./boost/boost/predef/compiler.h:16:47: fatal error: boost/predef/compiler/digitalmars.h: No such file or directory
compilation terminated.
make: *** [ramp.o] Error 1
ERROR: compilation failed for package ‘mzR’
* removing ‘/home/travis/build/sneumann/mzR/mzR.Rcheck/mzR’

@sneumann - does this sound familiar? Has there been a change that required to add this from boost into mzR?

lgatto commented 7 years ago

I have the same error locally.

sneumann commented 7 years ago

Which is strange, since there is a mzR/src/boost/boost/predef/compiler/digitalmars.h in the package, and the compiler flags says -I./boost/ . Also, the docker image compiles mzR successfully: DONE (mzR) in https://hub.docker.com/r/bioconductor/devel_protmetcore2/builds/b3bfsnsdkzxgksoxwmsntib/.

jorainer commented 7 years ago

No problem with macos.

lgatto commented 7 years ago

I manage to compile when removing

#include <boost/predef/compiler/digitalmars.h>

from compiler.h

lgatto commented 7 years ago

I am going to commit a version without that line, to address the request from Bioconductor. It would be good to get a better fix - I'm not going to close this issue yet.

sneumann commented 7 years ago

One thing that stymes me is that INSTALL works fine, while compilation during CHECK fails: Works:

g++ -std=gnu++11 -I/home/biocbuild/bbs-3.5-bioc/R/include -DNDEBUG -I./boost_aux/ -I./boost/ -I. -D_LARGEFILE_SOURCE -DHAVE_PWIZ_MZML_LIB -D_NODEBUG -DWITHOUT_MZ5   `nc-config --cflags || /bin/true`   -I"/home/biocbuild/bbs-3.5-bioc/R/library/Rcpp/include" -I"/home/biocbuild/bbs-3.5-bioc/R/library/zlibbioc/include" -I/usr/local/include   -fpic   -c ramp.cpp -o ramp.o

Fails:

g++ -std=gnu++11 -I/home/biocbuild/bbs-3.5-bioc/R/include -DNDEBUG -I./boost_aux/ -I./boost/ -I. -D_LARGEFILE_SOURCE -DHAVE_PWIZ_MZML_LIB -D_NODEBUG -DWITHOUT_MZ5   `nc-config --cflags || /bin/true`   -I"/home/biocbuild/bbs-3.5-bioc/R/library/Rcpp/include" -I"/home/biocbuild/bbs-3.5-bioc/R/library/zlibbioc/include" -I/usr/local/include   -fpic   -c ramp.cpp -o ramp.o
In file included from ./boost/boost/predef.h:13:0,
                 from ./boost/boost/smart_ptr/detail/yield_k.hpp:28,
                 from ./boost/boost/smart_ptr/detail/spinlock_sync.hpp:18,
                 from ./boost/boost/smart_ptr/detail/spinlock.hpp:50,
                 from ./boost/boost/smart_ptr/detail/spinlock_pool.hpp:25,
                 from ./boost/boost/smart_ptr/shared_ptr.hpp:34,
                 from ./boost/boost/shared_ptr.hpp:17,
                 from ./pwiz/data/msdata/RAMPAdapter.hpp:30,
                 from ramp.cpp:60:
./boost/boost/predef/compiler.h:16:47: fatal error: boost/predef/compiler/digitalmars.h: No such file or directory

sneumann / mzR

boost/predef/compiler/digitalmars.h missing #90