search

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis
Other
180 stars 80 forks source link

Request: filterPeaks() like method #541

Closed rickhelmus closed 3 years ago

rickhelmus commented 3 years ago

Hey guys,

I got a (hopefully small) request to have a way to remove peaks from an XCMSnSet object, similarly as could be done with xcms::peaks with the old xcmsSet interface. My main use case is to synchronize objects with those from patRoon. For now xcms:::.filterChromPeaks() does the job, but not quite ideal since it's not exported ;-) Ideally, this would leave grouping (features) intact.

Thanks, Rick

jorainer commented 3 years ago

Hi Rick! This is a very good suggestion indeed! I will make a filterChromPeaks method to allow filtering of peaks (and then obviously keeping the feature assignment correct).

rickhelmus commented 3 years ago

Excellent, many thanks!