sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis
Other
180 stars 80 forks source link

'concatenateSpectra' is not an exported object from 'namespace:Spectra' #556

Closed sneumann closed 3 years ago

sneumann commented 3 years ago

=> We'll need to bump the minimum Spectra version. Yours, Steffen

══ Failed tests ════════════════════════════════════════════════════════════════
── Error (test_functions-XCMSnExp.R:287:5): featureSpectra works ───────────────
Error: 'concatenateSpectra' is not an exported object from 'namespace:Spectra'
Backtrace:
    █
 1. └─xcms::featureSpectra(...) test_functions-XCMSnExp.R:287:4
 2.   └─xcms:::.spectra_for_features(...)
 3.     └─base::lapply(...)
 4.       └─xcms:::FUN(X[[i]], ...)
 5.         └─Spectra::concatenateSpectra
 6.           └─base::getExportedValue(pkg, name)
── Error (test_functions-XCMSnExp.R:687:9): .spectra_for_features works ────────
Error: 'concatenateSpectra' is not an exported object from 'namespace:Spectra'
Backtrace:
    █
 1. └─xcms:::.spectra_for_features(...) test_functions-XCMSnExp.R:687:8
 2.   └─base::lapply(...)
 3.     └─xcms:::FUN(X[[i]], ...)
 4.       └─Spectra::concatenateSpectra
 5.         └─base::getExportedValue(pkg, name)
sneumann commented 3 years ago

Ah sorry, 1.1.17 is already minimum version. Strange that my devtools::check(document = FALSE) didn't complain about the outdated 1.1.13 I had. Sorry for the noise, yours, Steffen