SSgauss: update for R 4.1

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis

Other

178 stars 81 forks source link

SSgauss: update for R 4.1 #563

Closed rickhelmus closed 3 years ago

rickhelmus commented 3 years ago

Hi guys,

Small compatibility update for R 4.1:

nls() now passes the trace and control arguments to getInitial(), notably for all self-starting models, so these can also be fit in zero-noise situations via a scaleOffset. For this reason, the initial function of a selfStart model must now have ... in its argument list.

Thanks, Rick

sneumann commented 3 years ago

Hi Rick, thanks for the PR ! I'll add your rationale to the NEWS and merge. Yours, Steffen

sneumann commented 2 years ago

Cool, pushed to BioC now. Will appear in the next days.