Fix build errors (issue #564)

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis

Other

178 stars 81 forks source link

Fix build errors (issue #564) #565

Closed jorainer closed 3 years ago

jorainer commented 3 years ago

Regarding 4.1 - this xcms is the current devel version for BioC 3.14 - and that should run on 4.1. I think we should try to avoid as much as possible running newer xcms versions on old R and BioC packages.

sneumann commented 3 years ago

Hm, not convinced. We should of course aim for the correct versions, and indeed with conda and containers it has become easier for users to stay on current versions, but unless technically necessary/beneficial I wouldn't force users to install current versions, not even supporting N-1. And, by allowing N and N-1 we might even be more robust. And of course, if necessary we bump dependency versions, but I wouldn't count the vignette there. Yours, Steffen

jorainer commented 3 years ago

I changed it back to magrittr - is it then OK for you if I merge it @sneumann ?