Jomain - Githubissues

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis

Other

178 stars 81 forks source link

Jomain #604

Closed jorainer closed 2 years ago

jorainer commented 2 years ago

This PR adds:

transformIntensity function.
fix issue #603

jorainer commented 2 years ago

@sneumann , can you please have a look at this PR, does not add much new things but fixes a bug/issue. If OK, please merge and push to BioC (along with the RELEASE_3_14 branch that contains the same fix).

sneumann commented 2 years ago

Looks good, and passes checks here. There is no unit test for #603, could one assemble such from the existing MS files ? Yours, Steffen

jorainer commented 2 years ago

you're right, there is none. AFAIK we don't have any (meaninful) MS1 and MS1+MS2 data in msdata we could use for that. I did test this locally on some of my data, but that's obviously not a real unit test.

sneumann commented 2 years ago

Maybe we can assemble a less meaningful test from existing mzMLs in msdata ?