search

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis
Other
177 stars 81 forks source link

There is a missing #621

Closed lennyleadership closed 2 years ago

lennyleadership commented 2 years ago

https://bioconductor.org/packages/release/bioc/vignettes/xcms/inst/doc/xcms.html

between figure 7 and 8,

It reads as:

summary_fun <- function(z)
    c(peak_count = nrow(z), rt = quantile(z[, "rtmax"] - z[, "rtmin"]))

It should read as:

summary_fun <- function(z) {
    c(peak_count = nrow(z), rt = quantile(z[, "rtmax"] - z[, "rtmin"]))
}
jorainer commented 2 years ago

Thanks for the comment. Actually, {} are not required if the code is within a single line. So, in R both:

add <- function(x, y) x + y

and

add <- function(x, y) {
    x + y
}

are valid.

I'm closing the issue now. Feel free to re-open if needed.