search

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis
Other
183 stars 80 forks source link

upcoming change in rgl will break xcms #656

Open sneumann opened 1 year ago

sneumann commented 1 year ago

See https://stat.ethz.ch/pipermail/bioc-devel/2023-January/019421.html for the message by Duncan, and the rgl Changelog https://dmurdoch.github.io/rgl/dev/news/index.html for functions to be deprecated. Needs 1) checking which function(s) use rgl functions, and 2) deciding whether to drop them, or migrate to the new rgl. Yours, Steffen

jorainer commented 1 year ago

Duncan already provided a fix (PR #654 ) that I just merged.

jorainer commented 1 year ago

hope my merge was not too quick - but I was in the middle of some other fixes and the provided fix seemed OK to me.

sneumann commented 1 year ago

Whoa, that was lightning fast :-) If I had gone through my mails in different order of folders, I might've found it :-) Thanks everyone ! Yours, Steffen