Updates and fixes - Githubissues

sneumann / xcms

This is the git repository matching the Bioconductor package xcms: LC/MS and GC/MS Data Analysis

Other

177 stars 81 forks source link

Updates and fixes #709

Closed jorainer closed 5 months ago

jorainer commented 6 months ago

Improve performance of the chromatogram call for XcmsExperiment objects.
Remove internal (not exported) normalization functions. These have been transferred to the MetaboCoreUtils package (https://github.com/rformassspectrometry/MetaboCoreUtils/pull/78).
Support subsetting of XcmsExperiment with negative indices (#707).

jorainer commented 6 months ago

Note: unit tests fail on ubuntu (and the Bioconductor docker image) because of internal changes in R devel. Because of this Rcpp, rlang and related packages fail to install (and hence also mzR, xcms etc).

jorainer commented 5 months ago

@sneumann @philouail , just a friendly reminder to eventually (if you find the time) have a look at this PR :)

sneumann commented 5 months ago

Hi, any need to bump dependency versions if code was moved to MetaboCoreUtils ? Otherwise looks good to me. Yours, Steffen

jorainer commented 5 months ago

Nope, no need for any version bump - this internal code that was refactored and moved to MetaboCoreUtils was never used within xcms (in any exported function).