snfactory / cubefit

Fit supernova + galaxy model on a SNFactory spectral data cube
MIT License
5 stars 5 forks source link

PSF artifacts #24

Open kbarbary opened 8 years ago

kbarbary commented 8 years ago

There are some SNe where the PSF model is pretty obviously wrong. Of the 30 SNe I test on locally:

LSQ12dbr (R):

lsq12dbr_r_timeseries

SN2005ki (B):

sn2005ki_b_timeseries

SN2005ki (R):

sn2005ki_r_timeseries

SN2006ac (B):

sn2006ac_b_timeseries

SN2011by (R):

sn2011by_r_timeseries

SNF20060512-002 (B):

snf20060512-002_b_timeseries

SNF20060512-002 (R):

snf20060512-002_r_timeseries

SNNGC4424 (R):

snngc4424_r_timeseries

SNNGC6801 (B):

snngc6801_b_timeseries

SNNGC6801 (R):

snngc6801_r_timeseries

kbarbary commented 8 years ago

Note that the ringing is caused by FFT shifting the PSF, but this is a separate issue. For example, running SN2005ki (B) with a fully resampled PSF (not FFT shifted) removes the ringing, but not the large scale residuals:

Fully resampled PSF:

sn2005ki_b_timeseries

FFT-shifted PSF (same as above):

ycopin commented 8 years ago

I don't understand how you can say this is coming from the PSF: which PSF, of which epoch? All epochs seem equally bad. Furthermore, the final model for the "fully resampled" and "FFT-shifted" PSF look rather different, while the PSF is the same.

PS: could you change the scale for the reference images, so that we could see if there's any structure in there?

kbarbary commented 8 years ago

As one concrete example, take this epoch from SNNGC4424 (R) as an example:

image

It seems to me that the PSF in this epoch is too wide, causing positive residuals at large radius and negative residuals at small radius. I suggested that it has at least something to do with the PSF because the only free parameters in cubefit at this stage are the position of the galaxy, the position of the SN, and the SN amplitude. Those all seem to be optimized pretty well - or at least, there's no way to change those parameters to make this residual go away.

Of course, this could be a problem with how cubefit is treating the PSF model, rather than the PSF model itself.

ycopin commented 8 years ago

But then I'm wondering why all the PSF of a SN sequence (and not only a couple of them) would be wrong at the same time.

kbarbary commented 8 years ago

Note: the scale labels on the residuals in the plots above are wrong. The residuals are actually typically on the scale of 1-5% (of the maximum value in the scene model). I won't repost all the images, but here's LSQ12dbr (R) for example:

image

(This is with resampled PSF fitting and subpixel sampling of 3x3, which is now the default.)