search

sni / Thruk

Thruk is a multibackend monitoring webinterface for Naemon, Nagios, Icinga and Shinken using the Livestatus API.
http://www.thruk.org
Other
406 stars 147 forks source link

add support for proxy configuration for Oauth #1393

Closed pbiering closed 1 week ago

pbiering commented 1 week ago

in internal environments it can be required to use a proxy to verify the token of an external provider, option added hereby

pbiering commented 1 week ago

looks like the failed citest is unrelated to the PR

sni commented 1 week ago

Thanks, one failed test is related:

Failed test 'Test::Perl::Critic for "lib/Thruk/Utils/OAuth.pm"' at t/099-Perl-Critic.t line 68.

Null statement (stray semicolon) at line 66, column 10. (no explanation). (Severity: 4) Looks like you failed 1 test of 269. t/099-Perl-Critic.t ..................................

Could you remove that semicolon, then it's ready to merge.

The other test is indeed unrelated. Latest chrome updates introduced lot of instability in the test cases.

pbiering commented 1 week ago

Could you remove that semicolon, then it's ready to merge.

done

sni commented 1 week ago

thanks for your contribution.