search

sni / lmd

Livestatus Multitool Daemon - Create livestatus federation from multiple sources
https://labs.consol.de/omd/packages/lmd/
GNU General Public License v3.0
42 stars 31 forks source link

Fix failing unparam tests #57

Closed jimorie closed 5 years ago

jimorie commented 5 years ago

After a recent update to the unparam tool it started reporting a couple of new errors in response.go. This commit addresses those errors to make unparam happy again.

The change in unparam that introduced the errors can be seen here: https://github.com/mvdan/unparam/commit/229ad68a599e2622cf9d3bb87a385b158efe736f

jimorie commented 5 years ago

The errors from unparam was:

response.go:615:73: (*Response).BuildLocalResponse - result 0 (error) is always nil
response.go:713:100: (*Response).BuildPassThroughResult - result 0 (error) is always nil
sni commented 5 years ago

strange, i thought i had fixed that already. Seems like i never pushed it. Had exact the same change prepared somewhere.

sni commented 5 years ago

thanks, merged.

jimorie commented 5 years ago

Nice. Thanks for the quick merge. :)

sni commented 5 years ago

you're welcome