Use more of the test dataset

sni / lmd

Livestatus Multitool Daemon - Create livestatus federation from multiple sources

https://labs.consol.de/omd/packages/lmd/

GNU General Public License v3.0

42 stars 31 forks source link

Use more of the test dataset #59

Closed jacobbaungard closed 5 years ago

jacobbaungard commented 5 years ago

Previously, when generating the host and service dataset, only the last host/service defined in the test data would be used.

This commit ensures that we use the actual dataset, and if more hosts or services than defined are needed, then we duplicate the last defined test object (as before).

Given that the test dataset used have changed, a bunch of the expected values in the tests needed to be adjusted.

Signed-off-by: Jacob Hansen jhansen@op5.com

jacobbaungard commented 5 years ago

Hmm seems to fail on the Go 1.x build (actual version seems to be 1.12), due to an unknown flag to the vet command (-shadow). Last master build on Go 1.x used 1.11.5, so guess something changed in Go 1.12.

sni commented 5 years ago

i will have a look. go 1.12 is pretty new and has been released only a few days ago.

jacobbaungard commented 5 years ago

https://golang.org/doc/go1.12#vet has some info.

sni commented 5 years ago

please rebase, should be fixed now

jacobbaungard commented 5 years ago

Great, rebased!

sni commented 5 years ago

perfect, thanks.