search

sni / lmd

Livestatus Multitool Daemon - Create livestatus federation from multiple sources
https://labs.consol.de/omd/packages/lmd/
GNU General Public License v3.0
42 stars 31 forks source link

Comments with info #65

Closed jacobbaungard closed 5 years ago

jacobbaungard commented 5 years ago

This PR adds the comments_with_info column to host and services.

Also the host_comments_with_info is added to all the relevant tables. I didn't manage to figure out a good way to have this value "inherited" down, with the rest of the host fields (using AddRefColumn). Instead they are explicitly added to each relevant table.

sni commented 5 years ago

looks good, except StringListCol does not sound right. Have you tried sorting by these columns? I am not expecting any useful result, but it should not panic :-)

jacobbaungard commented 5 years ago

Sorting doesn't really give any meaningful result (neither does livestatus it seems), but doesn't panic no. Changing to IntListCol on the other hand does cause panics. What type would you recommend?

I noticed the builds fails on one of the Go versions. Can't really see what formatting error it complains about in the log though.

sni commented 5 years ago

I guess this is a new type. InterfaceList would make sense. But i am fine with StringList as well. I just restarted the test, afaik travis had a few issues today.

sni commented 5 years ago

i remove go 1.10 from the travis builds :-) could you rebase please?

jacobbaungard commented 5 years ago

Ok. Also managed to fix the issue I think, but I have now rebased as well.

sni commented 5 years ago

thanks