search

snicker / gntp-regrowl

Regrowl GNTP Messages to Other Machines over Network
MIT License
7 stars 2 forks source link

config parsing in bridge/forward.py #3

Closed fracai closed 10 years ago

fracai commented 10 years ago

Line 68 of forward.py reads in the configuration file by joining the elements of the CONFIG_PATH array from cli.py

On the other hand, cli.py just passes in the array to parser.read().

The ConfigParser documentation indicates that read() will attempt to read each of the elements in the array. When I tested this it looks like this results in cli.py reading ~/.regrowl, while forward.py tries to read ~/.regrowl/.regrowl.

Unless there's something I'm missing, I think the 'join' shouldn't be there in forward.py.

I fixed this in my fork, as well as some later changes to how the config is read.

Thanks for your work (specifically with prowl).

snicker commented 10 years ago

Thanks! I'll get this merged in, I was wondering why things were screwy with that, but never chased it down, just applied a bandaid. I'm glad that someone else is benefiting from this.

On Oct 19, 2013, at 11:05, fracai notifications@github.com wrote:

Line 68 of forward.py reads in the configuration file by joining the elements of the CONFIG_PATH array from cli.py

On the other hand, cli.py just passes in the array to parser.read().

The ConfigParser documentation indicates that read() will attempt to read each of the elements in the array. When I tested this it looks like this results in cli.py reading ~/.regrowl, while forward.py tries to read ~/.regrowl/.regrowl.

Unless there's something I'm missing, I think the 'join' shouldn't be there in forward.py.

I fixed this in my forkhttps://github.com/fracai/gntp-regrowl/commit/ddeeb9c756eeef8ea45e83321df3dd68309974e7, as well as some later changes to how the config is read.

Thanks for your work (specifically with prowl).

— Reply to this email directly or view it on GitHubhttps://github.com/snicker/gntp-regrowl/issues/3 .

snicker commented 10 years ago

Merged in https://github.com/snicker/gntp-regrowl/commit/524c3cd54cf70f77d16c4f214da7f0bfc95f2e1c, thanks!

tortoo commented 3 years ago

@fracai Hi fracai, could you please take a look at this, thanks a lot! Prowl can receive notifications but the url seemed not to be delivered when the message forwarded to prowl. The notification received in prowl does not contain url.