horazont
commented
1 year ago I did some testing:
- Importing backups works
- Chatting, sending and receiving images works
-
Calling dino works (A + V), with the following caveats:
- Due to lack of a second phone, I only tested calls against dino
- Switching to Video in an audio call ends the call with App failure (according to MattJ, probably not a regression)
- If you open the dialpad, tap a number, then send Snikket into the background, and then pull it into foreground via the Notification, Snikket crashes with an IllegalStateException. Possibly also not a regression, should be investigated by someone who is not running this version yet.
There were two particular conflicts I'm sure I have resolved correctly:
In build.gradle, Snikket used:
implementation 'org.snikket:webrtc-android:107.0.0'while upstream Conversations is using:
implementation 'im.conversations.webrtc:webrtc-android:104.0.0'I went with upstream under the assumption that the Snikket thing was a temporary workaround until the build pipeline issues were resolved. If that's not the case, that needs addressing.
I also found 93c2fd4da699926a19a6c1eae268d7e8179c4cc6, indicating that there are some issues with broken video in webrtc >104, so I suggest we follow upstream here.
In
src/main/java/eu/siacs/conversations/ui/RtpSessionActivity.java, there was an add/add conflict on a line:dialpad.setVisible(isAudioOnlyConversation());switchToVideo.setVisible(isSwitchToVideoVisible());I took both. If that is not correct, that (and potentially related things) need fixing.
update: figured that one out myself, seems sensible to have both.