search

snikket-im / snikket-ios

Snikket iOS client
https://snikket.org/app/ios/
GNU General Public License v3.0
73 stars 10 forks source link

Snikket iOS keeps ringing after a call is stopped #29

Open mdosch opened 3 years ago

mdosch commented 3 years ago

If you try to start a call snikket iOS starts ringing, but if you decide to stop calling (because the person doesn't pick up or for other reasons) snikket iOS keeps ringing and doesn't stop. I assume that the stanza according to XEP0353 §3.2 is either not getting an important push by the server (prosody trunk with mod_cloud_notify on mdosch.de in my case) or snikket iOS is not reacting to it. It seems to be the reverse of #17

Steps to reproduce the behavior:

  1. A (Conversations) starts calling B (snikket iOS)
  2. B's snikket iOS starts ringing
  3. A stops calling
  4. B's snikket iOS continues ringing

Expected behavior I'd expect snikket iOS to stop ringing if the caller stops calling.

Details (please complete the following information):

mwild1 commented 3 years ago

I can't reproduce this on the latest version of the server + apps. Whether the phone is on/off and whether Snikket is in the foreground or not, the ringing reliably ends when the Android device hangs up.

Can you re-test with the latest version of all apps, and ensure you have all the new mod_cloudnotify* modules enabled and up to date?

mdosch commented 3 years ago

On 05.08.2021 04:30, Matthew Wild wrote:

I can't reproduce this on the latest version of the server + apps. Whether the phone is on/off and whether Snikket is in the foreground or not, the ringing reliably ends when the Android device hangs up.

I just checked and the iPhone 7 with iOS 14 and the latest test flight build from today continued ringing.

Can you re-test with the latest version of all apps, and ensure you have all the new mod_cloudnotify* modules enabled and up to date?

I tested with prosody (trunk nightly build 1493 (2021-07-29, 7d29167bfcc3)).

grep cloud_not /etc/prosody/prosody.cfg.lua
"cloud_notify";         -- For push notifications
"cloud_notify_encrypted"; -- For encrypted push notifications
"cloud_notify_filters"; -- Tigase push stuff
"cloud_notify_priority_tag"; -- Tigase push stuff
mwild1 commented 3 years ago

What was the software/version of the caller?

mdosch commented 3 years ago

Conversations 2.9.13+fcr

On 09.08.2021 04:57, Matthew Wild wrote:

What was the software/version of the caller?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/snikket-im/snikket-ios/issues/29#issuecomment-895162558