snikket-im / snikket-web-portal

This is the web portal for Snikket Chat services. To learn more about what Snikket Chat services are, check the website.
https://snikket.org
GNU Affero General Public License v3.0
32 stars 12 forks source link

Fallback locale is Danish causing inconvenience for user in other locales #131

Closed Raka-loah closed 2 years ago

Raka-loah commented 2 years ago

In infra.py, locale is decided using best_match from available locales or the first locale on the list: https://github.com/snikket-im/snikket-web-portal/blob/8bcf619cefe1fca477dd2f6705176402c23c4062/snikket_web/infra.py#L35-L40

Which is da, Danish, served as the default fallback locale when best_match is not available: https://github.com/snikket-im/snikket-web-portal/blob/8bcf619cefe1fca477dd2f6705176402c23c4062/snikket_web/__init__.py#L147-L156

For users in zh (Chinese) locale, best_match would fail and the whole site will use Danish locale. [insert frodo elvish meme here]

It's easy to fix this at runtime, just override the environ in snikket.conf: SNIKKET_WEB_LANGUAGES=en