search

sniklaus / pytorch-pwc

a reimplementation of PWC-Net in PyTorch that matches the official Caffe version
GNU General Public License v3.0
608 stars 122 forks source link

In run.py, self.netSix has out_channels = 196. Paper says 192. #54

Closed Etienne66 closed 2 years ago

Etienne66 commented 2 years ago

I reviewed the Caffe code in pwc_net_utils.py and it also has out_channels = 196. However their paper says it is supposed to be 192. See the 2nd 'Figure 4.' in PWC-Net: CNNs for Optical Flow Using Pyramid, Warping, and Cost Volume or 'Fig. 11' in their paper Models Matter, So Does Training: An Empirical Study of CNNs for Optical Flow Estimation

I'm guessing that can't be changed without retraining from scratch though. Does it even matter?

sniklaus commented 2 years ago

They probably meant to use 192 (2^7+2^6) in the code as stated in the paper but then accidentally used 196 instead. This cannot be changed without retraining, but it doesn't really matter either.