search

sniklaus / pytorch-pwc

a reimplementation of PWC-Net in PyTorch that matches the official Caffe version
GNU General Public License v3.0
621 stars 123 forks source link

Comparison with official's implementation #6

Closed yzcjtr closed 6 years ago

yzcjtr commented 6 years ago

Hi @sniklaus ,

Taking no account of modifications which have no impact on precision, such as coding style, what's the main factor that results in your implementation's improvement? Is it because of the correlation layer or something else? Thanks a lot.

sniklaus commented 6 years ago

The correlation layer is identical, it is just the weights that are different. The official PyTorch implementation initially was trained differently from the official Caffe version of PWC-Net. For this reason, I simply converted the official Caffe weights to PyTorch, thus making sure that it achieves the same quality.

yzcjtr commented 6 years ago

Thanks @sniklaus. Nice job.