sniklaus / youtube-watchmarker

a browser extension that keeps track of your YouTube watch history and marks videos that you have already watched
GNU General Public License v3.0
155 stars 19 forks source link

Watched badge showing when video hasn't been watched #115

Closed peachlilac closed 8 months ago

peachlilac commented 9 months ago

This started fairly recently. I started noticing that select videos I haven't watched are marked as watched by the extension. At first it was a different video that was marked, then I reset and synced my database and the videos marked changed. I only have the mark with the official YT watched badge option checked. I used to have the red bar thingy hidden but I had to turn it on to actually see if I watched it which kinda defeats the purpose of the badge? Here are screenshots, see how one vid has the red bar and one doesn't but both are marked as watched. I looked them up on the database using the search function but they don't show up.

sniklaus commented 9 months ago

Thank you for bringing this up, which version of the Watchmarker you are using? And when you refresh the page, are the incorrectly marked videos still marked as such?

peachlilac commented 8 months ago

It says version 4.5.1

Yes, refreshed the page, even closed the browser, turned my pc on and off, but the watched mark is still there for those videos. Weirdly enough I saw just now that a live stream waiting room is also marked as watched despite not clicking on it before and it not showing up on my history and database.

sniklaus commented 8 months ago

And if you search for the video in the Watchmarker's settings it doesn't show up? Have you tried searching for it using the video id (the part after the watch?v= in the URL)?

peachlilac commented 8 months ago

I tried that and they did show up but under different names. The first two was named the same as two other videos I actually watched. So I tried searching the titles again and they look like duplicates. Strange. Screenshot_2 Screenshot_3

This one is the live stream waiting room. Again, it was titled differently. I tried to delete it and this error showed presumably because YT doesn't show waiting rooms in official history. But the badge is gone now after deleting. Screenshot_4

Also, this one is labeled "Videos" on the database but when I clicked on it, it's a video I've watched but with a completely different title. Any idea why this happens? Screenshot_5

sniklaus commented 8 months ago

I just made some modifications, does the attached version improve things? Make sure to backup your database before you try.

Dryparn commented 8 months ago

I get the same problem and have been getting them for a couple of months.

L0relei commented 8 months ago

Same issue for me too.

Also, this one is labeled "Videos" on the database but when I clicked on it, it's a video I've watched but with a completely different title. Any idea why this happens? Screenshot_5

I have lines like this in my history, but with videos I didn't watched. I was able to reproduce it: whenever I visit a channel page, if there is a video above the section "Our Members", this video is added to the history of the extension with the name Videos. The video is neither in Youtube history (the extension throws an error when I manually delete it) nor Chrome history. The thumbnail shows the text WATCHED but without the date (option checked in my options) and there is no progressbar (I don't hide the progressbar in the options) If I click on the link, the name of the video and the date on the thumbnail appear.

I just made some modifications, does the attached version improve things? Make sure to backup your database before you try.

So far, it seems to be fixed with this version for me, thank you. Let's see in a few days :)

By the way: image

peachlilac commented 8 months ago

I just made some modifications, does the attached version improve things? Make sure to backup your database before you try.

I've had this version for about a week now and the main issue is fixed! The only thing I've noticed is when I started watching new videos, some of the video titles in the database are different.

Example title in database: 'Mix - [Creator Name]'

The actual video title is completely different. I wasn't able to take a screenshot of this, but I was able to solve it by resetting the database and synchronizing my account history. So far it hasn't happened again, and I don't know what I did for that to happen.

Not sure if I should still keep this open, so I'll leave it up to the creator @sniklaus. Thanks for solving the main issue!

sniklaus commented 8 months ago

Thanks everyone for chiming in! I released the version you guys tested, make sure to switch to a regular install to not miss out on future updates.

I have lines like this in my history, but with videos I didn't watched. I was able to reproduce it: whenever I visit a channel page, if there is a video above the section "Our Members", this video is added to the history of the extension with the name Videos.

Thank you for sharing this finding. Do you happen to have a link to a Youtube channel that has such an "Our Members" section? I looked at the ones I subscribe to and none do. :thinking:

So far, it seems to be fixed with this version for me, thank you. Let's see in a few days :)

Good news, thanks for letting me know!

I've had this version for about a week now and the main issue is fixed! The only thing I've noticed is when I started watching new videos, some of the video titles in the database are different.

Please don't hesitate to reach out again should this issue come back. Could very well be a bug.

L0relei commented 8 months ago

Thank you for sharing this finding. Do you happen to have a link to a Youtube channel that has such an "Our Members" section? I looked at the ones I subscribe to and none do. 🤔

For instance: https://www.youtube.com/@KatherineOfSky image

By the way, this is an example of a video that has been marked as watched by the extension but that I didn't watch and that isn't in my history (Youtube and Chrome) It was marked as watched before installing the new version.

So far, it seems to be fixed with this version for me, thank you. Let's see in a few days :)

Good news, thanks for letting me know!

I confirm that I no longer have the issue with the new version, thank you again!

sniklaus commented 8 months ago

Thank you for the prompt response and for sharing that Youtube channel! And I am happy to hear that the issue has been resolved for now, please don't hesitate to let me know should it resurface. :+1:

sniklaus commented 8 months ago

Closing this issue for now since it seems resolved? Please reopen if I am/was mistaken.

Dryparn commented 2 months ago

I'm sadly still having this problem on 4.6.1

Plugins: Alternate Player for Twitch.tv Enhancer for Youtube uBlock Origin Window Titler Youtube Watchmaker