search

sniklaus / youtube-watchmarker

a browser extension that keeps track of your YouTube watch history and marks videos that you have already watched
GNU General Public License v3.0
155 stars 19 forks source link

do Not connect to youtube.com, do Not do anything with the watch history stored on it #116

Open RedSteel-1 opened 8 months ago

RedSteel-1 commented 8 months ago

I noticed one thing: when I delete a video from the database, I see "3/4 locating it in the history on youtube" and then "error deleting video on youtube".

Do I understand it correctly that the extension tries to remove the video from the watch history on youtube itself? (in this case "error deleting video on youtube" would be expected cause I don't have a google/youtube account, so am never logged in)

If yes, could you add an option (and set it as default) to never connect and touch the watch history on youtube itself, and only touch the local extension's database?

sniklaus commented 8 months ago

If it fails to locate it in Youtube's history it is still deleted in the Watchmarker database and your browser history. So while this is annoying it is only taking longer due to having to wait for the Youtube lookup to fail.

I will change the behavior and only delete it from Youtube's history if "mark a video as watched once it appears in Youtube's watch history" is checked in the setting. Similarly, I will only delete it from the browser history if "mark a video as watched once it appears in the browser's history" is checked in the settings.

RedSteel-1 commented 8 months ago

Ya it takes longer, but this is not the main thing, the main point is that it connects to youtube.com to remove the video from its history, which is unwanted, I wanted to request to not connect to youtube, be offline, and only rely on and only delete videos from the extension's local db

I will change the behavior and only delete it from Youtube's history if "mark a video as watched once it appears in Youtube's watch history"

Similarly, I will only delete it from the browser history if "mark a video as watched once it appears in the browser's history" is checked in the settings.

And not touch the local db?

I would like to request an offline mode:

Actually, the issue #92 is pretty much close to this issue:

I hate when I accidentally open some video, and when I want to remove it from extension database, it says that it is removing it from YouTube's history. [...] So I'd like it to skip that step. Or add it as additional option.

sniklaus commented 8 months ago

but, never connecting to youtube.com and skipping the step "locating it in the history on youtube".

That's what I was suggesting as well. :+1: