snikproject / graph

Visualization of the snik-ontology.
http://www.snik.eu/graph
GNU General Public License v3.0
8 stars 3 forks source link

Layout (compound) fit view + option for colored edges #390

Closed sf87adin closed 2 years ago

sf87adin commented 2 years ago

Changed cose to grid mode to display as much nodes as possible.

Added option for colored edges.

KonradHoeffner commented 2 years ago

There should probably be a note on the compound layout that it only makes sense when combined matches are activated, then it looks a bit different:

Screenshot from 2022-10-21 14-42-20

With the changes from this pull request, all nodes are in the same grid (which comes from the grid mode):

Screenshot from 2022-10-21 14-42-32

Thus I will split this pull request and only merge the colored edges for now, which are very nice indeed, however the colors are very hard to see on my VA panel monitors, so I will crank up the brightness a tiny bit.

KonradHoeffner commented 2 years ago

Original colors (gray for non-interlinks, dark yellow for interlinks): Screenshot from 2022-10-21 14-50-52

Colored edges: Screenshot from 2022-10-21 14-51-15

KonradHoeffner commented 2 years ago

I tried to increase the brightness of the edges but the problem was the opacity of them because the original color was not gray but white with low opacity, so any other color would be less bright.

KonradHoeffner commented 2 years ago

I am not sure if the RGB color model is best with this algorithm, because the luminositiy may be different. Trying the HSL color model.

KonradHoeffner commented 2 years ago

Thanks for the PR, merged! (only the color part for now, though)

KonradHoeffner commented 2 years ago

P.S.: I did it manually, I think GitHub will see it as closed instead but at least your author information should be preserved. Hope that is OK.

sf87adin commented 2 years ago

Concerning the layout i was not aware the function does some more than displaying all visible nodes very small so nothing can be seen. grafik I will have another look on that and try to find a solution.

sf87adin commented 2 years ago

For the colors I added another pull request, hope the hierarchy is consistent. Pull request https://github.com/snikproject/graph/pull/392