snimavat / nimble

Nimble Security Grails Plugin
Other
15 stars 19 forks source link

compile issues with Grails 2.4.0 #50

Closed jguady closed 10 years ago

jguady commented 10 years ago

resources-1.2 and mail-1.0.1

image

mordka commented 10 years ago

In grails 2.4 resources plugin and static holder classes were removed. This makes nimble incompatible with 2.4 See: http://grails.org/doc/2.4.0.M1/guide/upgradingFrom23.html

tealsoftware commented 10 years ago

I got it to compile by

    compile(":nimble:0.7") {
        excludes("servlet-api", "hibernate", "grails-mail", "shiro", "twitter-bootstrap")
    }

    runtime ':twitter-bootstrap:2.3.2.2' // this is specially for Nimble as it is Bootstrap 2.3
    compile ":mail:1.0.6"
    compile ":shiro:1.2.1"

However, it now still fails through not finding the resources.

snimavat commented 10 years ago

Unfortulantely nimble has dependency on resources plugin, which was default for grails 2.3.x, (now grails has moved to asset pipe line). can you include the resources plugin in your buildconfig.

tealsoftware commented 10 years ago

I did include it, but I cannot use 'asset-pipeline' then as if both are included then it doesn't find the resources. Nevertheless, I've now commented 'asset-pipeline' and am now getting a StackOverflowError in 'twitter-bootstrap':

at org.groovydev.TwitterBootstrapTagLib$_closure1.doCall(TwitterBootstrapTagLib.groovy:36)
at org.groovydev.TwitterBootstrapTagLib$_closure1.doCall(TwitterBootstrapTagLib.groovy:36)

(I had to upgrade 'twitter-bootstrap' to 2.3.2.2 to be compliant with Grails 2.4). Not a Nimble problem per se, but still a blocker for me.

snimavat commented 10 years ago

Alright, does it work for you now ?

I'll try to get some time to upgrade nimble to grails 2.4.x

tealsoftware commented 10 years ago

After grails.plugins.twitterbootstrap.fixtaglib = true it seems to work.

It would be great if you could officially upgrade it to 2.4.x.

snimavat commented 10 years ago

I'll update soon.