Madsn
commented
9 years ago @rohitkumbhar upgrade to bootstrap 3 would be awesome! :+1:
Closed rohitkumbhar closed 7 years ago
Madsn
commented
9 years ago @rohitkumbhar upgrade to bootstrap 3 would be awesome! :+1:
rohitkumbhar
commented
9 years ago I have pushed my local changes for Bootstrap 3 to [https://github.com/rohitkumbhar/nimble/tree/upgrade](upgrade branch). It works for Grails 2.3.xx only. Using Grails 2.4 breaks a few dependent plugins.
I'll push it to master if it looks alright.
simonckenyon
commented
9 years ago What plugins don't work with 2.4? I ask because I just upgraded to 2.4 yesterday and after a lot of messing about I got it to work. I stayed on hibernate3, but shirk and twitter bootstrap worked fine.
rohitkumbhar
commented
9 years ago Twitter bootstrap needs to be updated to work with 2.4. Scaffolding and fields plugin need to be updated since they use deprecated classes. I don't think these would be needed after the bootstrap changes though. I haven't verified.
I couldn't get nimble-0.7 to start properly in 2.4 either. Some errors about tables not existing.
On Sat, Oct 11, 2014 at 11:51 PM, Simon Kenyon notifications@github.com wrote:
What plugins don't work with 2.4? I ask because I just upgraded to 2.4 yesterday and after a lot of messing about I got it to work. I stayed on hibernate3, but shirk and twitter bootstrap worked fine.
Reply to this email directly or view it on GitHub https://github.com/snimavat/nimble/pull/51#issuecomment-58775568.
Regards Rohit
rohitkumbhar
commented
9 years ago So, if you want you can discard this request and I can submit another pull request from the upgrade branch which has all these changes.
Another branch grails_2_4 has changes for 2.4 + using the asset-pipeline instead of resources. It is not compatible with Grails 2.3 though a version number change might be in order.
snimavat
commented
9 years ago It has to be compitible with grails 2.3.x
rohitkumbhar
commented
9 years ago So I created another two pull requests: https://github.com/snimavat/nimble/pull/55 - Bootstrap 3 upgrade and works with Grails 2.3 https://github.com/snimavat/nimble/pull/56 - All previous changes plus work for Grails 2.4. Does not work with 2.3
Regards Rohit
On Sun, Oct 12, 2014 at 11:43 PM, Sudhir Nimavat notifications@github.com wrote:
It has to be compitible with grails 2.3.x
Reply to this email directly or view it on GitHub https://github.com/snimavat/nimble/pull/51#issuecomment-58852065.
Regards Rohit
Hi, I have made a few changes to the nimble plugin. Can you please review the pull request?
I am working on upgrading to Bootstrap 3 and will send the pull request soon.
Regards Rohit