search

snipcart / snipcart-localization-v2

Localization files for Snipcart's shopping cart v2
https://docs.snipcart.com/v2/configuration/localization
MIT License
30 stars 114 forks source link

Adding Chinese (traditional-Taiwan) #89

Closed silverbow1 closed 5 years ago

silverbow1 commented 5 years ago

zh-TW.zip

JeanSebTr commented 5 years ago

Hi @silverbow1

Thanks for contributing!

Could you add the file directly to the locales folder and base your work on the master branch?

silverbow1 commented 5 years ago

Hello,

Yes, no problem, I'd like to do it, however I cannot upload file (I tried today). Seems I can only do another push request. Regards

Le lun. 11 mars 2019 à 23:16, Jean-Sébastien Tremblay notifications@github.com<mailto:notifications@github.com> a écrit :

Hi @silverbow1https://github.com/silverbow1

Thanks for contributing!

Could you add the file directly to the locales folder and base your work on the master branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/snipcart/snipcart-localization/pull/89#issuecomment-471581972, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AtV8zK1hOTdX5SzFoIde3rmIP8w8Evc-ks5vVnM3gaJpZM4bmnzC.

JeanSebTr commented 5 years ago

You can click "Create new file" from that page directly. image

You'll then be able to propose the changes as a new Pull Request.

I hope this helps!

silverbow1 commented 5 years ago

Hello,

Ok it is done. It seems I did it 2 times. One time empty (first time, I thought I could upload after), second time is correct. I apologize for that. Now I know.

About that, I tried to change the language in my website, following your instructions from your website, however, I cannot see any change, it’s still English. I checked several times, including for minor details that could be disturbing (as the $) for the last time) but I cannot see anything.

Any suggestion ?

Regards

Alexis

From: Jean-Sébastien Tremblay notifications@github.com Sent: Tuesday, March 19, 2019 2:02:14 AM To: snipcart/snipcart-localization Cc: silverbow1; Mention Subject: Re: [snipcart/snipcart-localization] Adding Chinese (traditional-Taiwan) (#89)

You can click "Create new file" from that page directlyhttps://github.com/snipcart/snipcart-localization/tree/master/locales. [image]https://user-images.githubusercontent.com/867435/54552359-44c95000-4986-11e9-8163-3a88c4cfaa30.png

You'll then be able to propose the changes as a new Pull Request.

I hope this helps!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/snipcart/snipcart-localization/pull/89#issuecomment-474034361, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AtV8zOo9qg5ij-rXzre535V2ci-YImUSks5vX9SmgaJpZM4bmnzC.

JeanSebTr commented 5 years ago

Thanks!

I've commented on PR #91 – it's almost ready to be merged 🙂

You can open a discussion on our support channel (login to the dashboard and you'll see the Intercom icon in the lower left corner). We'll be able to check with you why it doesn't work on your website!