snipe / downworthy

Source code for the Downworthy plugin
http://downworthy.snipe.net
208 stars 70 forks source link

Visually indicate when a swap has been performed #24

Open uberbrady opened 10 years ago

uberbrady commented 10 years ago

Perhaps optionally (with a checkbox or something)

But I would like something that looks visually distinct so I can be reminded that Downworthy has changed the content - I was thinking something like a zig-zaggy underline like MS Word's spellcheck, but it can be anything - just so long as it sticks out.

I think, implementation-wise, you would have to put your replacement text within a <span> that had some class that would never conflict with any of the CSS on the page - something like <span class="__downworthy_replacement"> - and find a way to add your stylesheet reference to the page - maybe an inline-stylesheet would be enough if there is only ever going to be one class in the stylesheet.

grahamc commented 10 years ago

May I suggest using this: https://github.com/wearefractal/blink-polyfill ?

shrikeh commented 10 years ago

You could have the icon change colour. Perhaps instead of a brown turd, it can be white like evil-smelling dogshit?

snipe commented 10 years ago

Actually, it does show a visual indicator, tho not as fun as yours. When it's on, it's poo. When it's off, it's poo with a red "OFF" label over the bottom third.

shrikeh commented 10 years ago

I saw that; I was thinking of making it have three states: turd replacement off, excrement replacement on, and fecal matter replaced.

uberbrady commented 10 years ago

I actually want some kind of textual indicator over the text that has been swapped so you have a reminder that the extension has done its work. It might be neat, too, to make it so that when you hover over the replaced text, you can see the original.

shrikeh commented 10 years ago

Perhaps a swarm of flies, then.

On Sat, Feb 1, 2014 at 11:55 PM, Brady Wetherington notifications@github.com wrote:

I actually want some kind of textual indicator over the text that has been swapped so you have a reminder that the extension has done its work. It might be neat, too, to make it so that when you hover over the replaced text, you can see the original.

Reply to this email directly or view it on GitHub: https://github.com/snipe/downworthy/issues/24#issuecomment-33887348