snipe / snipe-it

A free open source IT asset/license management system
https://snipeitapp.com
GNU Affero General Public License v3.0
11.21k stars 3.2k forks source link

Users Receiving Checkin Emails Though They Are Disabled In Settings #12890

Closed BPNetAdmin closed 1 year ago

BPNetAdmin commented 1 year ago

Debug mode

Describe the bug

New install and setup on IIS (Windows Server 2022). I have unchecked options to send checkin emails to users on the Category settings, as well as unchecking the Require Signature option in General Settings, however, users are still getting emails each time an asset is assigned to them, but only if the asset is a member of certain categories (other categories are not getting emails).

Reproduction steps

  1. Assign an asset to a user from one of troubled categories
  2. Checkin Email sent and received by user
  3. ...

Expected behavior

If checkbox cleared, no checkin emails should be sent, and all categories should turn same results if configured the same.

Screenshots

image

Snipe-IT Version

v6.1.0 Build 10161

Operating System

Windows Server 2022

Web Server

IIS

PHP Version

PHP 8.1.18

Operating System

Windows 10 Enterprise

Browser

Firefox

Version

112.0.1

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

welcome[bot] commented 1 year ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

mw-christensen commented 1 year ago

Something similar has been happening to us ever since we upgraded to the latest version of SnipeIT a few days ago. Admins are now getting daily "Expected asset checkin report" emails.

Admins are getting the digest email as well individual emails for things that are checked out (but no longer deployable). No other employees seem to be getting these emails even though they have similarly checked out (and non-deployable) items.

Perhaps this is expected behavior but it was not happening before the upgrade and I have no idea how to turn it on or off or why only admins would be notified.

marcusmoore commented 1 year ago

Thank you both for reporting. I confirmed @BPNetAdmin's issue and began working on a fix.

@mw-christensen I'll check out what you're reporting as well.

BPNetAdmin commented 1 year ago

@marcusmoore if you need me to send additional info or screen shares, just let me know.

I greatly appreciate your efforts so far.

BPNetAdmin

snipe commented 1 year ago

@mw-christensen to my knowledge, we haven't changed anything about that part. It's possible someone on your team added an address to the alerts email (Admin > Notifications), but we haven't touched that behavior in quite some time.

This also seems kinda unrelated to the OP's issue.

@BPNetAdmin can you show me (obfuscated, obviously) a example email that's new and problematic?

@marcusmoore and I have been working on this together, but Snipe-IT itself has a buttload of different config options and use cases, so it would help a lot. If you could also confirm for me whether or not you have "Require signature" in your Admin > General settings, that would help a ton.

BPNetAdmin commented 1 year ago

@snipe, I can verify that I have "Require signature" disabled in my general settings as this was one of my initial troubleshooting steps (sorry if I didn't lay that out a little better in the original post).

Also, I wouldn't necessary say that the emails are problematic, we just haven't trained users on the process yet which is why we had them disabled, so it is causing a little bit of a stir at the organization so i would definitely prefer a way to have them temporarily disabled.

It is emailing the following: image

Followed by the EULA that I created in the Category settings.

marcusmoore commented 1 year ago

@BPNetAdmin a temporary fix would be to clear the category EULAs. It's not explained to users but right now there is logic (a bug?) that checks to see if the category's EULA is populated and sends the user an email even when "Require users to confirm acceptance of assets in this category" and "Send email to user on checkin/checkout." are unchecked.

This workflow will probably change in the future and at least display some text explaining that behavior if it sticks around.

BPNetAdmin commented 1 year ago

@marcusmoore , thank you so much! I can absolutely use this workaround and this explains why it is only certain categories experiencing this behavior.

This will work for my needs, and then I can just add the EULA back in once the user training is complete and they are watching for the documentation.

Thank you so much, great support and great response!

BPNetAdmin commented 1 year ago

@marcusmoore, I am marking as closed as this solves my issue