snipe / snipe-it

A free open source IT asset/license management system
https://snipeitapp.com
GNU Affero General Public License v3.0
9.91k stars 3.01k forks source link

Added Proper Docker Compose and .env.docker-setup files #14724

Closed phil-flip closed 23 hours ago

phil-flip commented 1 month ago

Description

For a while now @svpernova09 and I have been planning on rewriting the Docker Docs so it uses Docker compose, instead of Docker run. That requires us to change some stuff in the repo. Like having a docker-compose.yml and .env.docker file which can be used by the user.

This Pr should help with getting less support inquiries in the Discord Docker channel and remove docker run from production deployments.

Thankies to @svpernova09 for helping me brainstorm about possible solutions and providing the health checks for the docker-compose.yml

Type of change

How Has This Been Tested?

The updated article can be read in the docs. But I tested my setup, by running the following commands.

Checklist:

welcome[bot] commented 1 month ago

πŸ’– Thanks for this pull request! πŸ’–

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

Things that will help get your PR across the finish line:

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

what-the-diff[bot] commented 1 month ago

PR Summary

phil-flip commented 1 month ago

Thankies for the compliments. ^^ I had a feeling that because of the upcoming release there are not going to be made a lot of changes to v6. Tho I would prefer to merge it now as it should make a difference, unless the application stack changes (different DB, other backend, etc...)

snipe commented 23 hours ago

Thank you ❀️

welcome[bot] commented 23 hours ago

Congrats on merging your first pull request! πŸŽ‰πŸŽ‰πŸŽ‰

phil-flip commented 22 hours ago

@snipe Thank you for merging. Mind also merging the changes in the Docs?

snipe commented 1 hour ago

Done :)