search

snipe / snipe-it

A free open source IT asset/license management system
https://snipeitapp.com
GNU Affero General Public License v3.0
11.12k stars 3.19k forks source link

Obsolete Asset Assignment in Notifications #15609

Open DaMa-IT opened 1 month ago

DaMa-IT commented 1 month ago

Debug mode

Describe the bug

The notification system is incorrectly displaying assets that belong to a different company. This is causing confusion and preventing users from taking any actions.

Reproduction steps

  1. Log into Snipe-IT.
  2. Navigate to the notifications page.
  3. Click on a notification that indicates an asset requiring acceptance.
  4. Observe the asset details and note the assigned company.
  5. Verify that the assigned company does not match the user's company.

Expected behavior

The notification should only display assets that belong to the user's company. in our case we only have one company profile created and we have not enabled the support for multiple companies

Screenshots

image_720 image_720

Snipe-IT Version

v7.0.13 build 15514 (gdc0949da7)

Operating System

Ubuntu

Web Server

NGINX

PHP Version

8.1.2-1ubuntu2.19

Operating System

Windows 11 Pro 23H2

Browser

Chrome

Version

Version 129.0.6668.60 (Official Build) (64-bit)

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

DaMa-IT commented 1 month ago

@snipe Please have a look when you can. Thank you.

snipe commented 1 month ago

Without FMCS, I can't reproduce this.

Screenshot 2024-10-11 at 2 19 51 PM Screenshot 2024-10-11 at 2 20 03 PM Screenshot 2024-10-11 at 2 20 15 PM
DaMa-IT commented 1 month ago

Hi Snipe, We never enabled FMCS actually and I just double checked and its not enabled. Could this be caused by a deleted asset which were assigned to a user ?

snipe commented 1 month ago

It's possible? I know we did some cleanup there a while back, but I don't think it would have fixed existing data (specifically adding a checkin action when an asset is deleted)

DaMa-IT commented 1 month ago

I see. What do you suggest at this point ? I even purged the deleted records hoping that it might clear any remains but that didn't work either. Its really annoying the the user as the notification banner cannot be cleared or resolved.

snipe commented 1 month ago

Well, I wouldn't have purged those, since now we don't know what their IDs were in the assets table. My guess is that there are vestigial records in the checkout_acceptance table, but without knowing which asset IDs are gone, it will be hard to pull them out.

DaMa-IT commented 4 weeks ago

Can we like have an option to ignore and clear the notification banner? or even better if we can control whether the user has to accept the asset or not.