1D barcode taking space on label even when hidden

samweber commented 8 years ago

Expected Behavior (or desired behavior if a feature request)

When unchecking "Display 1D barcode" in the Barcodes Setting, it should hide the space that the 1D barcode would have taken up when generating asset labels.

Actual Behavior

Instead, the space where the 1D barcode would have been, there is an empty white space. It hides any text that is underneath it.

Please confirm you have done the following before posting your bug report:

[X] I have enabled debug mode
[X] I have read checked the Common Issues page

Please provide answers to these questions before posting your bug report:

Version of Snipe-IT you're running: v3.3.0-3-g7ef4f23
What OS and web server you're running Snipe-IT on: Ubuntu 14.04.4
What method you used to install Snipe-IT (install.sh, manual installation, docker, etc): install.sh
If you're getting an error in your browser, include that error: N/A
What specific Snipe-IT page you're on, and what specific element you're interacting with to trigger the error: /hardware/bulkedit
Confirm whether the error is reproduceable on the demo. Yes, reproduceable.
Indicate whether or not you've manually edited any data directly in the database. Not edited.

samweber commented 7 years ago

Until this is resolved, I manually overrode the CSS in /var/www/snipeit/resources/views/hardware/labels.blade.php to the exact label I will be using.

Bingmano commented 7 years ago

I am having this issue as well, is this on track to being resolved?

snipe commented 6 years ago

This was fixed in #4354

snipe / snipe-it