snipe / snipe-it

A free open source IT asset/license management system
https://snipeitapp.com
GNU Affero General Public License v3.0
10.81k stars 3.13k forks source link

[Feature Request] Improved Consumables interface. #2534

Open ghost opened 8 years ago

ghost commented 8 years ago

Hi,

We've just started using Snipe, it's been pretty useful thus far. Though managing consumables is a little finicky.

Ideally for our situation you should be able to check in new consumables when we receive them, rather than editing them manually.

Thanks

cryogenx commented 3 years ago

@snipe any news on this one? the product is solid except for this... id be willing to send some budgetary dollars that way if it would help move the feature up the list.

ruddens commented 3 years ago

+1 on this please :)

Solverz-0 commented 2 years ago

Is there plans for this feature to be added?

xotan135 commented 2 years ago

Over the years I have following this thread. I have come to the conclusion that they will adamantly ignore this thread until the last dev quits due to old age

On Fri, Oct 29, 2021, 06:53 Solverz-0 @.***> wrote:

Is there plans for this feature to be added?

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/2534#issuecomment-954681288, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWB6ZR7IKNOPLHEVHX5RL3UJKKLVANCNFSM4COGTCKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

xXValiXx commented 2 years ago

+1 . Please add this feature because I donΒ΄t know how to use consumables the right way.

ghost commented 2 years ago

+1, this would be important to our team if we were to adopt snipe-it

KimmoJ commented 2 years ago

I'm honestly surprised nothing has happened in what, two years? Granted, the project chooses what they want to work on or not but still, it seems like a minor tweak at best that some would find quite useful. In our case, well... we've moved on to more automated ways of maintaining stock of things that might otherwise have been used here, so for us it's less of a priority now. Because we've moved on.

ntaylor-86 commented 2 years ago

Just cloned the repo and looked into adding this feature.

2022-06-02_15-52-09

Fumbling my way through it 😡

Are the maintainers still up for adding this? What's the best place to ask for help this feature?

ntaylor-86 commented 2 years ago

Alright, this is where I'm leaving it for tonight;

Replenish button on the Consumables page, 2022-06-02_23-15-55

Replenish Consumable form, 2022-06-02_23-16-42

Success Consumable replenished successfully, 2022-06-02_23-17-05

Solverz-0 commented 2 years ago

@ntaylor-86 This looks great, but I think it would work a lot better if instead of the "Total" increasing, the "remaining" should be increased instead.

For example, you know you will always want a total of no more than 10 reels of paper, you checkout 4 reels and now you have a remaining 6 reels. So you replenish this stock by ordering 4 reels and then you increase the remaining stock back up to 10 without affecting the total stock so the total still shows as 10 so you know how many max you should try to have.

sabait commented 2 years ago

I disagree, the total and remaining should be increased to know how many you have added in total. If you only increase remaining what happens if you add 10 when your total is 10 and your remaining is 5? Total 10, remaining 15? Makes no sense. Max has little use for inventory purposes... if you do need to have that reference, you could add it as part of the name since it should never change.

To add to what is being worked on... I would add a Note for this form like the checkout has for consumables. That way you can include a PO number or any other information relevant to the increase in inventory.

Solverz-0 commented 2 years ago

@sabait I see your reasoning, however no if you added 10 to the remaining when you total is 10 and your remaining is 5 then the total would be increased to 15 and the remaining increased to 10.

I disagree, max has little use for inventory purposes if you are buying and selling stock but for consumable stock it matters a lot as you do not want the person who orders the consumable stock to buy more than needed, only to top up the remianing to the total.

Tracking how many you have purchased over a certain period with the total is a feature I do not think is really relevent in an asset management system or should be an additional value. for example, total purchased and you can filter between dates etc.

ghost commented 2 years ago

@ntaylor-86 This is awesome, thank you for getting this implemented!

landor commented 2 years ago

Any chance there is any kind of audit / log of the replenish transaction (who, when, quantity)? Or is it just a shortcut for modifying the Quantity in the "Update Consumable" screen? (Still awesome) Thanks!

On Thu, Jun 2, 2022 at 9:22 AM Nathan Taylor @.***> wrote:

Alright, this is where I'm leaving it for tonight;

Replenish button on the Consumables page, [image: 2022-06-02_23-15-55] https://user-images.githubusercontent.com/28693782/171638316-cafb5622-101b-4937-8293-aa2fa2440222.jpg

Replenish Consumable form, [image: 2022-06-02_23-16-42] https://user-images.githubusercontent.com/28693782/171638514-335c543f-41e5-4085-a949-b6beb0bbb3af.jpg

Success Consumable replenished successfully, [image: 2022-06-02_23-17-05] https://user-images.githubusercontent.com/28693782/171638795-4231d303-9dcd-4bcb-b02d-6280ba1d6f7a.jpg

β€” Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/2534#issuecomment-1144859643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHZBZ2Z4MUJJHOKSV5RWPTVNCYSZANCNFSM4COGTCKQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

xotan135 commented 2 years ago

Gaw I have not seen this much activity on this thread in years

On Thu, Jun 2, 2022, 13:58 Landor @.***> wrote:

Any chance there is any kind of audit / log of the replenish transaction (who, when, quantity)? Or is it just a shortcut for modifying the Quantity in the "Update Consumable" screen? (Still awesome) Thanks!

On Thu, Jun 2, 2022 at 9:22 AM Nathan Taylor @.***> wrote:

Alright, this is where I'm leaving it for tonight;

Replenish button on the Consumables page, [image: 2022-06-02_23-15-55] < https://user-images.githubusercontent.com/28693782/171638316-cafb5622-101b-4937-8293-aa2fa2440222.jpg

Replenish Consumable form, [image: 2022-06-02_23-16-42] < https://user-images.githubusercontent.com/28693782/171638514-335c543f-41e5-4085-a949-b6beb0bbb3af.jpg

Success Consumable replenished successfully, [image: 2022-06-02_23-17-05] < https://user-images.githubusercontent.com/28693782/171638795-4231d303-9dcd-4bcb-b02d-6280ba1d6f7a.jpg

β€” Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/2534#issuecomment-1144859643, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAHZBZ2Z4MUJJHOKSV5RWPTVNCYSZANCNFSM4COGTCKQ

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

β€” Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/2534#issuecomment-1145207613, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWB6ZWDKTLUQMQ7YMF2IMTVND75FANCNFSM4COGTCKQ . You are receiving this because you commented.Message ID: @.***>

ntaylor-86 commented 2 years ago

The logs of the replenish transaction is the next goal. I'll create a new table to store the transaction and display all of the the transactions on the individual consumable page

2022-06-03_8-09-24

snipe commented 2 years ago

I don't think we want to create new tables for that - it would go in the action logs table, so it can be reflected in the overall activity log.

ntaylor-86 commented 2 years ago

Thanks @snipe I'd like to stick to conventions as much as possible!

veenone commented 2 years ago

Just want to let you know guys that I have PR #10856 about this topic pushed some times ago. I think it's the same thing that being discussed here but with a little bit difference on the process. Any feedback are welcomed

ntaylor-86 commented 2 years ago

Looks good @veenone πŸ‘

veenone commented 2 years ago

If you see something is missing in my pr, please let me know @ntaylor-86 πŸ™‚

xotan135 commented 8 months ago

The logs of the replenish transaction is the next goal. I'll create a new table to store the transaction and display all of the the transactions on the individual consumable page

2022-06-03_8-09-24

did your changes ever get merged ?

ntaylor-86 commented 8 months ago

Hey @xotan135,

I put my development of this feature on hold after seeing @veenone already had such a detailed pull request in progress.

xotan135 commented 8 months ago

gaw i thought i had seen in one of the patch notes they had added this feature i guess i was mistaken. i pulled a docker container down to take a look at it again and the replenish feature i still didn't see there.

On Mon, Dec 18, 2023 at 11:42β€―PM Nathan Taylor @.***> wrote:

Hey @xotan135 https://github.com/xotan135,

I put my development of this feature on hold after seeing @veenone https://github.com/veenone already had such a detailed pull request in progress.

β€” Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/2534#issuecomment-1862157345, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWB6ZRE7NUP7F5E2KIN363YKESN5AVCNFSM4COGTCK2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGIYTKNZTGQ2Q . You are receiving this because you were mentioned.Message ID: @.***>