search

snipe / snipe-it

A free open source IT asset/license management system
https://snipeitapp.com
GNU Affero General Public License v3.0
11.18k stars 3.2k forks source link

Parent and Child locations, and quantities #4546

Open MSWork79 opened 6 years ago

MSWork79 commented 6 years ago

Expected Behavior (or desired behavior if a feature request)

CHS - Parent CHS Business Lab - Child

CHS - 2 assets CHS Business Lab - 25 assets

Expected Location CHS to have a total of 27 assets reported. (Parent + Child = Total)

Actual Behavior

CHS has 2 assets and does not factor in child quantities.

parent child qty

Please confirm you have done the following before posting your bug report:

Provide answers to these questions:

I have 25 assets assigned to a child location, and presently, the parent location does not reflect the quantity of assets in the child location.

Tried to reproduce, but there weren't any child locations and while I made one, I couldn't make a user move to it so I could manipulate the assets/locations/etc.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/52176454-parent-and-child-locations-and-quantities?utm_campaign=plugin&utm_content=tracker%2F505106&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505106&utm_medium=issues&utm_source=github).
snipe commented 6 years ago

That's a level of recursion hell I personally don't want to mess with right now. :(

MSWork79 commented 6 years ago

No worries. The locations page is pretty solid as it is.

snipe commented 6 years ago

Hah - "I don't wanna" isn't really a sufficient reason to close this ticket though. It's a valid feature request, it's just hard and it's been a long week. :P

snipe commented 6 years ago

weepandthendie

MSWork79 commented 6 years ago

head-pat-gif-5

MSWork79 commented 6 years ago

We'll have close to 2,500 to 3,000 assets in the system once I get all this stuff figured out. So it would be really nice to get a quick glance of each facility quantities, as well as specific breakdowns of child locations. Take your time though, it's not hard to just stare at the /locations page a little bit longer. Maybe with a calculator.

snipe commented 6 years ago

Hm. How many levels of nesting do you have for locations? The problem is never the first level to child level, it's the one user who has like 50 levels of recursion.

MSWork79 commented 6 years ago

I foresee only nesting one level, maaaaaybe two?

MSWork79 commented 6 years ago

Company technically covers the highest level of "Location" here, so: Company - Our School District Parent Location - Campus (x3), Office Buildings (x1), District employees that aren't assigned to one campus (x1) Child Locations - If we were going to do it by room, we could do it here. We're only going to be doing it for labs and more permanent-type things. Teachers switch rooms and what not, and we don't want to try and track that. Anything else I can think of would still fall under the primary Parent location so I can't think of why I would need a deep nest of locations.

snipe commented 6 years ago

@MSTigers unrelated to totals right now, but I just pushed out some changes to the locations and suppliers details pages that I think you might like. You now get WAY more info and actions on both.

screen shot 2017-12-01 at 9 22 14 pm screen shot 2017-12-01 at 10 06 29 pm
MSWork79 commented 6 years ago

Looking good! Sorry for delayed feedback. I thought I had replied when I checked it out.

MSWork79 commented 6 years ago

So previously we weren't going to have a lot of locations - but that's going to change. The nesting levels will still be the same. We are going to be utilizing locations for each classroom and then, pending further investigation, assigning teachers as a manager of that location or just assigning that teacher to that location.

Some assets will be assigned to the teacher, while other semi-permanent assets will be assigned to the room. Projectors, for example, will be location based and not follow a teacher around when they move.

Schools are complicated!

MSWork79 commented 6 years ago

District - Parent Level Admin Buildings (Child of District) Tech Dept (Child of District) Tech Infrastructure - Parent Level Campus - Parent Level Classroom (Child of Campus)

Because the fact that company is there, that's the upper most parent. I have not had the need to go beyond 1 nest, Parent <-> Child, location. All of the above parents and their child locations are part of Company, so if I want to view all assets I can do that.

I could understand the need of someone's child locations having a deeper nest of child locations under it Parent -> Child (who is now a parent, but not THE parent) -> (Grand)Child ->Etc. but I myself have no need of it. I could see it being a major, MAJOR pain trying to say OK, Parent location as 5 devices to itself, and all of the children total have 10, so parent has 15. Child has 8, and grandchild has 2, so child technically has 10, but don't count it as 10 when adding to the parents total - and then trying to develop a system that will adapt to people adding more and more nested locations.

Clearly I'm bias because I don't need to go more than 1 nested level (parent -> child), but I'd be in favor of restricting how many nests is allowed. Or perhaps, an option that says "If you have more than one nested level of parent/child locations, the cumulative total function will be disabled) or something. That way people who do need to have A parent that has a child, that has a child, that has another child, with another child (5 generations!!) can still do it. They just won't get the math done for them beyond what it is currently doing.

Also pretty pictures: parent child map

ketonic commented 6 years ago

Just would like to add that this feature would be quite valuable for us! In our case it would be use like this: Company (our School federation) Campus (the 5 different schools in our federation) -- Parent Building (A,B,C) -- Child of Campus Floor (100,200,300) -- Child of Building Room (121,231,312) -- Child of Floor

As we are talking about 5500 computers, 1000 external monitors, around 300 projectors and 300 speakers this feature would be really handy for us too very easily to find and sort out our equipment when its time to replace and upgrade.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

MSWork79 commented 6 years ago

Only thing stale here are my jokes

On Sun, Jun 3, 2018, 3:40 AM stale[bot] notifications@github.com wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/4546#issuecomment-394146619, or mute the thread https://github.com/notifications/unsubscribe-auth/Afv4DmkuWObGt5dpXRIKXai5IneYETtOks5t46DmgaJpZM4QxVGP .

stale[bot] commented 6 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

snipe commented 6 years ago

I'm not sure why this was marked as stale. According to the rules we use, tagged feature requests/ready for dev issues shouldn't be marked as stale. :-/

stale[bot] commented 6 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

ketonic commented 6 years ago

Bump?

stale[bot] commented 6 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

MSWork79 commented 6 years ago

Stale bot does not care about your silly rules, lol

stale[bot] commented 5 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

MSWork79 commented 5 years ago

oi

stale[bot] commented 5 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

decyphered commented 5 years ago

i'll throw in another oi for us

denhyde commented 5 years ago

And another oi. This feature would be really useful. Currently it prevents me from migrating to Snipe-it. I need to include assets in all rooms and floors of a particular building in a custom asset report. Thank you!

MSWork79 commented 5 years ago

Discussion!

Assuming every location at 5 assets,

Campus (Parent) 5 (20) Building (Child of Campus) 5 (15) Floor (Child of Building) 5 (10) Room (Child of Floor) 5

I think this is the most realistic setup, so I would (as bias mentioned early) say that in order to reduce the complexity of implementation, that we restrict the level of nesting to accommodate for the above. This should also apply to businesses. If they need more than City > Building > Floor > Room, then I suggest they make a separate company or something.

Does anyone have a scenario that the above would not cover that would be an issue for you? I don't need this many levels, but I don't want to encourage Snipe to implement something that only benefits a small group. I also do not want to overly complicate the implementation to the point that it doesn't get implemented either.

Sxderp commented 5 years ago

I'm not sure about the naming but that number of levels would work for most of our use case. The way we label item locations is generally: Building Room [Section of Room]

Section of room is used mostly for our larger storage rooms that we pile things in. Though we do have the rare case were we have a few extra levels for server racks.

... Rack Number Rack Unit

For example:

"Skiles": {
  "155": {
    "155-0": {},
    "155-1": {},
    "155-2": {},
    "155-3":  {}.
    "155-4": {},
    "155-5": {},
    "155-6": {},
    "155B" { # Subroom in the room
      "155B-r1": { # Server rack
        "155B-r1u10",
        "155B-r1u20",
        "155B-r1u30"
      },
      "155B-r2": {
        "155B-r2u10",
        "155B-r2u20",
        "155B-r2u30"
      }
    }
  }
}
twisted3motions commented 5 years ago

We would only need Building, Floor, Room.... So 3-4 levels would be fine.

kan3 commented 5 years ago

Bumping this thread. Would love to have this feature for our campus, can show visual representation if required too.

Thank you in advance.

stale[bot] commented 5 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

ketonic commented 5 years ago

Go to sleep again mr Stale :)

stale[bot] commented 5 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

Nevets82 commented 5 years ago

We also would love this feature. So I gave it a try. Comments are welcome.

Ink0gn1tos commented 5 years ago

I'm adding my vote for this feature. It would be very useful. That feature could be then used at "View Assigned Asset", where managers of each location could easily see, not just their own devices, but also devices of location which are responsible for.

d90 commented 5 years ago

I also feel this feature would be beneficial. I work at a university and being able to see all devices on a given campus without using custom fields would be amazing.

kgortmak commented 5 years ago

Yup. Me too :-) Now if the same nesting would also work for location manager, that would be awesome as well. If no manager listed on a child, parent manager should be able to manage that location. That way you can delegate to other location managers. ANd come to think about it, how about to assign multiple managers to a location?

Knightrain0 commented 5 years ago

Yes, this feature would be great to have!

smyers119 commented 5 years ago

+1 for this

viclou commented 5 years ago

+1 FD

Odel commented 4 years ago

This would be a great addition!

dwhiteearly commented 4 years ago

+1 for this. This would be a useful feature. Just curious, without this feature, what is the Parent-> Child feature for?

DomRVA commented 4 years ago

+1

sgharib23 commented 4 years ago

This feature would be great! Pls implement this!

barau83 commented 4 years ago

+1. Would be great if it could at least be an export option under 'Custom Asset Report'. Then we can tick Location AND Parent Location.

kendzioc commented 4 years ago

+1. Would be a great feature.

darhei commented 4 years ago

+1. Would be very useful.

jo395 commented 4 years ago

+1 for this.

stale[bot] commented 4 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!