snipe / snipe-it

A free open source IT asset/license management system
https://snipeitapp.com
GNU Affero General Public License v3.0
11.12k stars 3.19k forks source link

Feature Request - Review and modify expected check-in dates #5762

Closed MSWork79 closed 8 months ago

MSWork79 commented 6 years ago

Server (please complete the following information):

Is your feature request related to a problem? Please describe. Yes. The problem I have is when an employee's contract is not renewed/retiring/etc., we often know the dates ahead of time, some times a month or more in advance. Previously their assets when checked-out had no "expected" check-in date. This has changed but I cannot update Snipe-IT to reflect this.

Describe the solution you'd like To be able to view an asset's expected check-in date and then be able to modify it. E.g., previously there was no expected date, but now it will be Oct 31, 2018. This way when their deadline comes up and have yet to check-in their assets we can track through the same fashion of an asset that had an expected check-in date.

Describe alternatives you've considered 3rd party reminders/notifications/tracking that would basically say "Go check Snipe on this date to see if they still have assets out.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/60295828-feature-request-review-and-modify-expected-check-in-dates?utm_campaign=plugin&utm_content=tracker%2F505106&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505106&utm_medium=issues&utm_source=github).
gvlterr0r commented 6 years ago

This would be a great feature to have, we have the same scenario with employees and contract dates.

romannazarenko commented 6 years ago

+1

hixair commented 6 years ago

+1 We often have employees contracts extended and it's not really convenient to have to checkin and checkout devices to put a new expiry date. By the way, i send all my love to the project team, Snipe-IT is so nice and convenient, made a big part of our work a lot easier. HUGE Thanks !!!!!

stale[bot] commented 6 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

MSWork79 commented 6 years ago

Yep still relevant stale bot. shoos

stale[bot] commented 6 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

gvlterr0r commented 6 years ago

Yes please

On Fri, Sep 28, 2018, 6:34 AM stale[bot] notifications@github.com wrote:

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/5762#issuecomment-425407877, or mute the thread https://github.com/notifications/unsubscribe-auth/Am0HN-ayicgqZscBeBuKyqic5CfUb7VVks5ufglQgaJpZM4U9UN2 .

stale[bot] commented 5 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

hixair commented 5 years ago

It is still relevant. Thank you stale bot, I know you only do you job ;)

stale[bot] commented 5 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

stale[bot] commented 5 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

hixair commented 5 years ago

Still relevant. Come back after v5 is out !

stale[bot] commented 5 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

MSWork79 commented 5 years ago

Preemptive stalebot shooing. Still very interested in this as well. Would be incredibly convenient for tracking assets in relation to getting them back from users in a timely, organized fashion.

renardeau commented 5 years ago

+1 I'm new to snipe-IT, but as far as I understood, there is no possibility to edit the check-out data. We do experience a need to update the expected check-in date, but also other check-out fields like the notes.

viclou commented 5 years ago

+1 FD#10829

hegdemaahi24 commented 5 years ago

+1

ajsy commented 5 years ago

+1 btw from database you can update the expected check-in

fkick commented 5 years ago

+1 on this...we deal with a lot of freelancers who often get extended or wrap early depending on shifting project due dates and this would be a great help.

@ajsy how are you updating from the database?

Thanks!

ajsy commented 5 years ago

I'm using phpmyadmin web console the table name is assets the column name is expected_checkin

Picture

Please note: manually editing data in database is not recommended, unless you know what you are doing

aldervall commented 5 years ago

+1. I would also take a look at accountExpires Attribute in LDAP. Implement a reminder email before it expires. It's quite often that users have an AD account that get prolonged. Should reduce the hassle of editing endates in 2 instanses.

avassdal commented 5 years ago

+1

MBSMC commented 5 years ago

I would also be interested in modify expected check-in dates so that way when we find out someone is leaving the organisation the date can be updated to follow up with them.

hixair commented 5 years ago

I realize that I would like to have this feature and I would like to be able to update it via API too ! We update our directory and home tools with the end date we get from the HR suite, would be great to edit asset end dates as well !

gitthismoney commented 5 years ago

+1!

sambayford commented 5 years ago

+1 duplicate of https://github.com/snipe/snipe-it/issues/5522

MSWork79 commented 5 years ago

+1 duplicate of https://github.com/snipe/snipe-it/issues/5522

Dang you got me! I'm normally pretty good about finding duplicates first. This one made it a year and a half.

stale[bot] commented 4 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

hixair commented 4 years ago

It is !

stale[bot] commented 4 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

maxlehot1234 commented 4 years ago

Anything @snipe ? ;)

stale[bot] commented 4 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

maxlehot1234 commented 4 years ago

It is

Sent with GitHawk

stale[bot] commented 4 years ago

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

jhamernik commented 4 years ago

Still relevant - much needed feature

G13312 commented 4 years ago

Still relevant! A much needed addition since we dont always know when an employee is leaving and also good to track assets that havent been returned in time!

MSWork79 commented 4 years ago

COVID hit, I've got about 500+ devices spamming out email notifications for needing to be checked in since we changed our return policy (extending possession through the summer).

This is unpleasant. Disabling email alerts doesn't seem to stop them from going out either.

image

sean-borg commented 4 years ago

@snipe I am interested in fixing this issue however am a little unsure how best to implement the fix and wanted to get some feedback on my thoughts of a potential fix.

My current ideas are

Open to other suggested fixes :)

hixair commented 4 years ago

Looks great ! The way I was expecting it to work : using the edit button for the check-out asset (asset update page), you should be able to edit a form item with the current date, select a new date and save to update !

G13312 commented 4 years ago

Same as @hixair ! Going in a checked-out asset > Actions > Edit Asset then be able to edit the Expected Checkin Date from there would be the best way imo. Would also be great to be able to see it in Reports, great for tracking assets that are not returned in time.

Thanks!

MSWork79 commented 4 years ago

As I mentioned a few comments above, disabling it doesn't seem to have any effect. While I would love to be able to modify/change the expected date, I need to fix my problem now. Anyone know of a way to STOP it from sending out notifications, besides the obvious of going into .env and removing email settings?

I do not want to go through and manually check-in/check-out every single asset all over again.

MSWork79 commented 4 years ago

So clarification from my original request.

Describe the solution you'd like To be able to view an asset's expected check-in date

This CAN be viewed in the Asset View page image

and then select the field in the columns display image

Result: image

Just wanted to clarify that you can indeed VIEW the expected check-in dates. Of course, even if you try to slipstream an import, you have to map it which you can't do (hence this feature request).

image

aldervall commented 4 years ago

@snipe I am interested in fixing this issue however am a little unsure how best to implement the fix and wanted to get some feedback on my thoughts of a potential fix.

My current ideas are

* Having expected checkin date as link similar to Manufacturer, category and model.
  Clicking link will take you to an edit date page.

* Add another option in the actions tab "Update expected Checkin date"
  Clicking the option will take you to an edit date page.

* Being able to edit date directly in the View Asset > details page.
  This idea I'm very unsure about it doesn't really fit with the rest of the page and having looked at how the
  table is loaded it could become unnecessarily  complicated

Open to other suggested fixes :)

Iam guessing alot of snipe-it users are importing Users/Accounts via LDAP/AD. To correlate the attribute "accountExpires" with "Expected Checkin Date" or to have that option when you checkout a device.

So whenever you do a LDAP sync the Expected Checkin Date are changed equal to what LDAP says. And iam guessing HR systems are getting their information from LDAP/AD or vice versa.

This is just my take on it :)

Thanks @sean-borg for taking a look.

hixair commented 4 years ago

Wow this is actually the best way to do it in my opinion too ! We are already leveraging the accountExpires date for a lot of thing, makes sense to set an expected checkin date !

Le 9 juil. 2020 à 02:22, aldervall notifications@github.com a écrit :

@snipe https://github.com/snipe I am interested in fixing this issue however am a little unsure how best to implement the fix and wanted to get some feedback on my thoughts of a potential fix.

My current ideas are

  • Having expected checkin date as link similar to Manufacturer, category and model. Clicking link will take you to an edit date page.

  • Add another option in the actions tab "Update expected Checkin date" Clicking the option will take you to an edit date page.

  • Being able to edit date directly in the View Asset > details page. This idea I'm very unsure about it doesn't really fit with the rest of the page and having looked at how the table is loaded it could become unnecessarily complicated Open to other suggested fixes :)

Iam guessing alot of snipe-it users are importing Users/Accounts via LDAP/AD. To correlate the attribute "accountExpires" with "Expected Checkin Date" or to have that option when you checkout a device.

So whenever you do a LDAP sync the Expected Checkin Date are changed equal to what LDAP says. And iam guessing HR systems are getting their information from LDAP/AD or vice versa.

This is just my take on it :)

Thanks @sean-borg https://github.com/sean-borg for taking a look.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/5762#issuecomment-655824144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSBGVXP77QPJ6XC7DRDTR2UEUBANCNFSM4FHVIN3A.

MSWork79 commented 4 years ago

I would advise caution as mentioned above, for anything that's automated to be flexible or the ability for it to be optional. The sync/LDAP/automated seems pretty cool of course, but back in July of 2018 I referenced #5864 "User's Resignation Date" as it was discussed there briefly to tie those two together. I still am against it, especially if A.) is required and B.) holds up the implementation of this feature due to complexity.

Me in 2018, and me now:

I personally wouldn't want anything done automatically with this besides an email notification saying "past expiration/past resignation."

fkick commented 4 years ago

I agree with @MSTigers and would prefer that the extension have a manual option rather then be tied to the AD attribute. We often see case of HR misfiling wrap dates were AD would be incorrect as we deal with a lot of free lancers. Manually being able to set the extension date would be preferable in those circumstances.

hixair commented 4 years ago

Or maybe add a checkbox to the LDAP settings to select to sync the dates or not ?

Le 9 juil. 2020 à 15:07, fkick notifications@github.com a écrit :

I agree with @MSTigers https://github.com/MSTigers and would prefer that the extension have a manual option rather then be tied to the AD attribute. We often see case of HR misfiling wrap dates were AD would be incorrect as we deal with a lot of free lancers. Manually being able to set the extension date would be preferable in those circumstances.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/5762#issuecomment-656116200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSBB25CJQQVBIU2E2IELR2W6JLANCNFSM4FHVIN3A.

aldervall commented 4 years ago

Maby as easy as this

Maybe?

sean-borg commented 4 years ago

Iam guessing alot of snipe-it users are importing Users/Accounts via LDAP/AD. To correlate the attribute "accountExpires" with "Expected Checkin Date" or to have that option when you checkout a device.

So whenever you do a LDAP sync the Expected Checkin Date are changed equal to what LDAP says. And iam guessing HR systems are getting their information from LDAP/AD or vice versa.

This is just my take on it :)

Thanks @sean-borg for taking a look.

I like the idea however I think this may be better as a separate request :)

Unfortunately with my current knowledge of snipeit and LDAP I wont be able to tackle it. But should be different enough to warrant another feature request :)

stale[bot] commented 4 years ago

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!