search

snipsco / Postal

A Swift framework for working with emails
MIT License
652 stars 81 forks source link

BUGFIX: IndexSet.unreleasedMailimapSet was creating range one longer … #45

Closed matadan closed 7 years ago

matadan commented 7 years ago

…than expected.

klefevre commented 7 years ago

Thanks for the bugfix but unfortunately It's not enough because all IndexSet conversion are based on a CountableRange basis. If you run LibetpanConversionTests you'll see that lot of tests will fail =/

matadan commented 7 years ago

OK :(

On 11 Feb 2017, at 11:55, Kevin Lefèvre notifications@github.com wrote:

Thanks for the bugfix but unfortunately It's not enough because all IndexSet conversion are based on a CountableClosedRange basis. If you run LibetpanConversionTests you'll see that lot of tests will fail =/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snipsco/Postal/pull/45#issuecomment-279139371, or mute the thread https://github.com/notifications/unsubscribe-auth/ABe-sBhEiXzWf46QvrBDbrqev5C50Z-Jks5rbaHNgaJpZM4L-J__.

matadan commented 7 years ago

How do I run the tests?

klefevre commented 7 years ago

@matadan To run tests just press ⌘ + U in Xcode. I've made my own PR based on your changes here #46. Thanks a lot for having pointed out this bug 👍

matadan commented 7 years ago

You’re welcome. Thanks for making this framework in the first place.

On 11 Feb 2017, at 12:09, Kevin Lefèvre notifications@github.com wrote:

@matadan https://github.com/matadan To run tests just press ⌘ + U in Xcode. I've made my own PR based on your changes here #46 https://github.com/snipsco/Postal/pull/46. Thanks a lot for having pointed out this bug 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snipsco/Postal/pull/45#issuecomment-279139906, or mute the thread https://github.com/notifications/unsubscribe-auth/ABe-sN-hUYqDrmwtskrzMuMHP2nqf5QAks5rbaTegaJpZM4L-J__.