snipsco / Postal

A Swift framework for working with emails
MIT License
652 stars 81 forks source link

Clean up from Xcode 10.2 changes #84

Closed ktkopone closed 5 years ago

ktkopone commented 5 years ago

As mentioned in the recent XCode 10.2 PR thread: https://github.com/snipsco/Postal/pull/83#issuecomment-485564820

klefevre commented 5 years ago

This should be fixed by #85. Don't hesitate to give a try. I'll wait for feedback before releasing a new version. Thanks

ktkopone commented 5 years ago

Thanks! Looks mostly good, noticed one more warning upon re-opening XCode about an english language setting being deprecated:

Screen Shot 2019-05-07 at 1 18 58 PM

the prompted auto-fix did the following and seemed to resolve it:

diff --git a/Postal.xcodeproj/project.pbxproj b/Postal.xcodeproj/project.pbxproj

index c06c1f9..3eed3be 100644
--- a/Postal.xcodeproj/project.pbxproj
+++ b/Postal.xcodeproj/project.pbxproj
@@ -584,10 +584,9 @@
                        };
                        buildConfigurationList = 98DB008F1CEC6983003CAABB /* Build configuration list for PBXProject "Postal" */;
                        compatibilityVersion = "Xcode 3.2";
-                       developmentRegion = English;
+                       developmentRegion = en;
                        hasScannedForEncodings = 0;
                        knownRegions = (
-                               English,
                                en,
                                Base,
                        );