Closed ktkopone closed 5 years ago
This should be fixed by #85. Don't hesitate to give a try. I'll wait for feedback before releasing a new version. Thanks
Thanks! Looks mostly good, noticed one more warning upon re-opening XCode about an english language setting being deprecated:
the prompted auto-fix did the following and seemed to resolve it:
diff --git a/Postal.xcodeproj/project.pbxproj b/Postal.xcodeproj/project.pbxproj
index c06c1f9..3eed3be 100644
--- a/Postal.xcodeproj/project.pbxproj
+++ b/Postal.xcodeproj/project.pbxproj
@@ -584,10 +584,9 @@
};
buildConfigurationList = 98DB008F1CEC6983003CAABB /* Build configuration list for PBXProject "Postal" */;
compatibilityVersion = "Xcode 3.2";
- developmentRegion = English;
+ developmentRegion = en;
hasScannedForEncodings = 0;
knownRegions = (
- English,
en,
Base,
);
As mentioned in the recent XCode 10.2 PR thread: https://github.com/snipsco/Postal/pull/83#issuecomment-485564820
Result module was removed but is still referenced in Postal.podspec. I don't use pods in my project so I'm not sure what issues this may cause.
Postal-iOS framework has 7 swift language-related warnings: