snipsco / snips-actions-templates

Template files for snips actions
11 stars 24 forks source link

Standardize on a configuration format (actions use ini, snips daemons uses toml) #10

Open hcooper opened 6 years ago

hcooper commented 6 years ago

The /etc/snips.toml file is where a lot of central configuration options live for snips (e.g. which MQTT host to use). The file is in toml[1] format.

The snips actions-template system presumes that the action's config file will be a ini file (and is read by the ConfigParser module).

ConfigParser doesn't like importing toml files. For instance is throws ParsingError() when there's a space at the start of the line, and doesn't expect strings to be within quotes.

Using two different configuration systems means configs can't be shared (with a lot of manually-added boilerplate to read the toml file). It would be good to standardize, so that actions can easily read the same configs the snips daemons are using.

[1] https://en.wikipedia.org/wiki/TOML

maxbachmann commented 5 years ago

@anthonyray shouldn´t this be fixed with #18 ?