snipsco / snips-issues

Feel free to share your bugs with us.
14 stars 5 forks source link

snips/duration “quarter of an hour" is not understood by ASR #125

Closed jenskastensson closed 5 years ago

jenskastensson commented 5 years ago

What's the issue? When the Snips’ builtin slot type for duration (snips/duration) is used the ASR doesn’t understand the word for duration in fraction such as “quarter of an hour” “half an hour” etc.

Use Cases Impacted Timer setting

How to reproduce Say: Command for half an hour ASR will understand as Command for seven hours. When the same command is tested in the console it works as expected (quarter = 15 min)

Expected behavior ASR understands the words: quarter, half, three quarters of an hour.

Version and Environment Platform Version: Snips 0.61.1 OS: Raspbian Stretch 9.8

Logs

Additional information

cpoisson commented 5 years ago

hi @jenskastensson,

I see two differences regarding the console:

Did you tried your assistant with the latest version of the platform on your Pi?

jenskastensson commented 5 years ago

Hi @cpoisson and thank you for the reply! The problem persists after upgrade to Snips core v0.62.3 (details below)

Note that when we test the command in the console, we type the command ( the mike of the computers are not good enough to be trusted)

dpkg-query --show snips-* snips-analytics 0.62.3 snips-asr 0.62.3 snips-asr-injection snips-asr-service snips-audio-server 0.62.3 snips-dialogue 0.62.3 snips-hotword 0.62.3 snips-injection 0.62.3 snips-kaldi snips-kaldi-atlas 0.24.2 snips-nlu 0.62.3 snips-platform-common 0.62.3 snips-platform-voice 0.62.3 snips-queries snips-skill-server 0.62.3 snips-template 0.62.3 snips-tts 0.62.3 snips-watch 0.62.3

francescocalta commented 5 years ago

Thanks for your feedback @jenskastensson ! We identified the origin of the problem and will be fixed by the end of next week.

jenskastensson commented 5 years ago

Great and thank you for the feedback!

cpoisson commented 5 years ago

Hi @jenskastensson ,

Should be solved now.

You need to re train your assistant and re install it on your platform.

I'm closing this issue, do not hesitate to re open if this problem still exists.

jenskastensson commented 5 years ago

We've tested and the issue and it is solved, thanks!

jenskastensson commented 5 years ago

The problem is solved in English, however there are a similar problems in French and German:

  1. eine halbe stunde is understood as eine stunde.
  2. un (et trois) quart d'heure is is understood as 3 jours
  3. drei virtel stunde is is understood as 12 hours

Can you please re-open the issue ?

flatsiedatsie commented 5 years ago

I was just about to open an issue: duration slot does not support "in an hour and a half"? when I noticed this one.

{
  "input": "in an hour and a half remind me to turn on the tv",
  "intent": {
    "intentName": "createcandle:set_timer",
    "confidenceScore": 0.9890741
  },
  "slots": [
    {
      "rawValue": "an hour",
      "value": {
        "kind": "Duration",
        "years": 0,
        "quarters": 0,
        "months": 0,
        "weeks": 0,
        "days": 0,
        "hours": 1,
        "minutes": 0,
        "seconds": 0,
        "precision": "Exact"
      },
      "range": {
        "start": 3,
        "end": 10
      },
      "entity": "snips/duration",
      "slotName": "duration"
    },
    {
      "rawValue": "remind me to",
      "value": {
        "kind": "Custom",
        "value": "reminder"
      },
      "range": {
        "start": 22,
        "end": 34
      },
      "entity": "timer_type",
      "slotName": "timer_type"
    }
  ]
}