search

snipsco / snips-issues

Feel free to share your bugs with us.
14 stars 5 forks source link

[Injection] Let application to be aware of injection end/success/fail #193

Open deniseBrise opened 4 years ago

deniseBrise commented 4 years ago

Is your feature request related to a problem? Please describe. My request is related to problem : Injection fail when JSON contains empty value #192 It would be intersting to know when an injection is in progress (or finished). Currently we can rely on message "hermes/asr/reload" or "hermes/nlu/reload" when injection is successful, but nothing happen on fail.

What are the use cases of this feature Let application to be aware of injection end/success/fail.

Describe the solution you'd like Adding messages with injection end/success/fail information would be appreciable.

Describe alternatives you've considered Relying on "hermes/asr/reload" or "hermes/nlu/reload" messages in case of success.

Additional context

cpoisson commented 4 years ago

Hi @deniseBrise,

Injection complete will be available in the next release. Failure info is planned for the one after.

You'll be updated on this ticket when those feature are available.

Thanks again for your feedbacks

cpoisson commented 4 years ago

Partially fixed in version 1.3.0

If the injection fail, the completion message will not be emitted.