search

snipsco / snips-issues

Feel free to share your bugs with us.
14 stars 5 forks source link

Revive timed out sessions #34

Open Psychokiller1888 opened 6 years ago

Psychokiller1888 commented 6 years ago

Being able to revive timed out, but not ended, sessions would be very usefull

fredszaq commented 6 years ago

@Psychokiller1888 could you give an example on when this would be useful ?

Psychokiller1888 commented 6 years ago

Keeping a stream open when / if needed. The exemple I can give is my laryngophone to pilot my drone

Simple commands should end normally. But when pilote mode is engaged, I do not use the hotword anymore, I just give orders, like "up 10", "left 45", "forward 120".

It is easily doable by listening for endSession, by recreating a new session without sound feedback. But you loose the basic session payload. Ok, I can keep it in an array, but that's a lot of ok for something that could be core side

fredszaq commented 6 years ago

ok so more of a "continue listening till user command in the future" mode ? cc @Garvys could we have a mode like this in asr endpointing ?

Psychokiller1888 commented 6 years ago

Yeah, would work too. But the NLU has to be triggered

fredszaq commented 6 years ago

of course^^ but the root would be the asr

Psychokiller1888 commented 5 years ago

I have seen since a while something like "revived_from" in the mqtt payloads, lower level... Does this mean you've been on it @fredszaq ?

fredszaq commented 5 years ago

The field has been there from the beginning ^^ didn't find time to work on it just yet

Le mar. 6 août 2019 à 23:43, Psycho notifications@github.com a écrit :

I have seen since a while something like "revived_from" in the mqtt payloads, lower level... Does this mean you've been on it @fredszaq https://github.com/fredszaq ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snipsco/snips-issues/issues/34?email_source=notifications&email_token=AALKUOHKTHUBU3DQ7WTFS2TQDHWARA5CNFSM4FGUKOOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WRVEY#issuecomment-518855315, or mute the thread https://github.com/notifications/unsubscribe-auth/AALKUOGUMBDPMTHCYHA6F7DQDHWARANCNFSM4FGUKOOA .

Psychokiller1888 commented 5 years ago

Woot? Never saw it actually... I was getting my hopes up :-)