Description
At the moment, FileBasedConfiguration and ZipBasedConfiguration construction logic relies on an hardcoded filename (which is trained_assistant.json).
This seems wrong in terms of testing, code clarity and future-proof-ness.
Instead, these objects should be initialized by passing an additional filename parameter.
Description At the moment,
FileBasedConfigurationandZipBasedConfigurationconstruction logic relies on an hardcoded filename (which istrained_assistant.json). This seems wrong in terms of testing, code clarity and future-proof-ness.Instead, these objects should be initialized by passing an additional
filenameparameter.