search

snipsco / snips-nlu-rs

Snips NLU rust implementation
https://snips.ai
Other
340 stars 56 forks source link

Add BytesBasedConfiguration #24

Closed warent closed 6 years ago

warent commented 6 years ago

I've applied some of your changes, but the amount of time I can commit to this is limited. For now, this is as much as I can do. Please feel free to take over this PR

adrienball commented 6 years ago

Hey @warent , I'm closing this PR because we have refactored how a SnipsNLUEngine is persisted and loaded, see #58 . The trained engine json file has been replaced by a directory, hence the new API to load an engine is:

impl SnipsNluEngine {
    pub fn from_path<P: AsRef<Path>>(path: P) -> Result<Self> { ... }
    pub fn from_zip<R: io::Read + io::Seek>(reader: R) -> Result<Self> { ... }
}

Cheers Adrien