search

snipsco / snips-nlu-rs

Snips NLU rust implementation
https://snips.ai
Other
340 stars 56 forks source link

Improve caching of builtin entity parsing #49

Closed adrienball closed 6 years ago

adrienball commented 6 years ago

Description The caching of builtin entity parsing is now the responsibility of the client code. This PR improves the caching strategy by only caching the parsing of builtin entity when the resolved value is not used, and disabling caching otherwise. Indeed, datetime resolved values must not be cached as they may be relative to the current context (e.g. in 5 minutes).

klefevre commented 6 years ago

Would be nice to start having some bench in here