snipsco / snips-nlu

Snips Python library to extract meaning from text

https://snips-nlu.readthedocs.io

Apache License 2.0

3.89k stars 513 forks source link

Accept ambiguous results from DeterministicIntentParser #797

Closed adrienball closed 5 years ago

adrienball commented 5 years ago

Description: Ambiguous results (confidence score < 1.0) from the DeterministicIntentParser were systematically discarded. This PR lowers the threshold to 0.5 to allow for slight ambiguities.

Checklist:

[x] My PR is ready for code review
[x] I have added some tests, if applicable, and run the whole test suite, including linting tests
[x] I have updated the documentation, if applicable

codecov-io commented 5 years ago

Codecov Report

Merging #797 into develop will not change coverage. The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #797   +/-   ##
========================================
  Coverage    88.42%   88.42%           
========================================
  Files           76       76           
  Lines         4570     4570           
  Branches       882      882           
========================================
  Hits          4041     4041           
  Misses         397      397           
  Partials       132      132