snipsco / snips-nlu

Snips Python library to extract meaning from text

https://snips-nlu.readthedocs.io

Apache License 2.0

3.9k stars 513 forks source link

Fix possible override of entity values when generating variations #808

Closed adrienball closed 5 years ago

adrienball commented 5 years ago

Description: When augmenting the dataset, variations of utterance entity values were added without checking possible collisions with other utterance entity values.

Checklist:

[x] My PR is ready for code review
[x] I have added some tests, if applicable, and run the whole test suite, including linting tests
[ ] I have updated the documentation, if applicable

adrienball commented 5 years ago

addresses #807

codecov-io commented 5 years ago

Codecov Report

Merging #808 into develop will increase coverage by 0.03%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #808      +/-   ##
===========================================
+ Coverage    88.38%   88.42%   +0.03%     
===========================================
  Files           76       76              
  Lines         4590     4588       -2     
  Branches       890      889       -1     
===========================================
  Hits          4057     4057              
+ Misses         396      395       -1     
+ Partials       137      136       -1

Shotgun167 commented 5 years ago

I'm having some issues where slots are sometimes filled with the word that has the case changed, ie. password is changed to Password. We are working around the issue by referencing the rawvalue for the slot. I''m wondering if this is a result of the same issue.

adrienball commented 5 years ago

@Shotgun167 This is indeed very likely to be caused by this issue.