snipsco / snips-skill-respeaker

Official Snips Animation Feedback For Makers Kits/Dev Kits, supporting all kinds of APA102 based LED hardwares.
MIT License
41 stars 23 forks source link

Please add username and password for MQTT as configuration option #8

Closed JasperZ closed 6 years ago

JasperZ commented 6 years ago

Hi,

I would like to use this skill on my Raspberry Pi Zero W running only the snips-audio-server as a sattelite device. The problem is that I need a configuration option to set the username and password for an external MQTT server.

So I would suggest to add these as configuration options to the config.ini file like this:

# MQTT
mqtt_host=ip_address_of_host
mqtt_port=port_of_host
mqtt_username=username_used_for_mqtt
mqtt_password=password_used_for_mqtt

Thanks in advance Jasper

CoorFun commented 6 years ago

Hi,

Thanks for your feedback. I will implement it as soon as possible.

CoorFun commented 6 years ago

Hi Jasper,

I have pushed the version that supports username/ password for mqtt connection on the branch c-dev.

You can have a test for your use case. It will be merged to the master soon.

To install this branch c-dev, you can use sam(On PC):

sam install actions -g https://github.com/snipsco/snips-skill-respeaker.git -b c-dev

Beware that you may need to manually remove the old action code folder(On Raspberry): /var/lib/snips/skills/snips-skill-respeaker

JasperZ commented 6 years ago

Hey,

I just tried it and it works great, no problems at all! Thx for the quick implementation!!!