search

snipsco / tensorflow-build

A set of scripts to (cross-)build the Tensorflow C lib for various architectures / OS
MIT License
178 stars 92 forks source link

fix tensorflow.so for latest master #5

Closed daschl closed 7 years ago

daschl commented 7 years ago

Hi,

we fixed tensorflow_c to tensorflow in the upstream crate, so this change makes it still possible to work with the upcoming release. Or if you want tensorflow = { git = "https://github.com/tensorflow/rust" }

daschl commented 7 years ago

@fredszaq wdyt? I'm still being hopeful for https://github.com/Homebrew/homebrew-core/pull/10273

fredszaq commented 7 years ago

nice !

see also the PR here for the inclusion of the formula in homebrew

we'll also need to rename the libs in the debs (can you include it in the pr ? I'll do it otherwise)

daschl commented 7 years ago

@fredszaq if you could do the deb part that would be great, I don't have a quick box here to verify that :)

fredszaq commented 7 years ago

done here : https://github.com/snipsco/tensorflow-build/pull/6

I'll just wait for it to build before merging the two PRs

fredszaq commented 7 years ago

@daschl do you have and ETA for the next version of the rust tensorflow crate ?

daschl commented 7 years ago

@fredszaq nope I'm just contributing, @adamcrume maybe does :)

adamcrume commented 7 years ago

We don't have a release schedule for tensorflow/rust, but I could certainly cut a release if there's a need for it.

fredszaq commented 7 years ago

@adamcrume I would appreciate it, we use the scripts from this repository to install systemwide versions of tensorflow and cut the building time on our rust projects at snips, and we always prefer no having to depend on unreleased versions (moreover, the current 0.2 version of the crate builds TF 0.12 and the 1.0.0 is out)

adamcrume commented 7 years ago

I just released version 0.3, which builds TensorFlow 1.0.0, although it doesn't take advantage of any new features.

fredszaq commented 7 years ago

Thanks Adam !

Le 3 mars 2017 5:43 AM, "Adam Crume" notifications@github.com a écrit :

I just released version 0.3, which builds TensorFlow 1.0.0, although it doesn't take advantage of any new features.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/snipsco/tensorflow-build/pull/5#issuecomment-283864175, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaqOPvj3i7dTz95l_J54cN9SNU3g5-mks5rh5p_gaJpZM4MPecf .